From: "Jean-Noël AVILA" <jn.avila@free.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, worldhello.net@gmail.com
Subject: Re: [PATCH] i18n: remove i18n from tag reflog message
Date: Wed, 03 May 2017 18:38:45 +0200 [thread overview]
Message-ID: <2070499.EYhsb04HyH@cayenne> (raw)
In-Reply-To: <xmqqwpa1ic4e.fsf@gitster.mtv.corp.google.com>
Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit :
> Jean-Noel Avila <jn.avila@free.fr> writes:
> > The building of the reflog message is using strbuf, which is not
> > friendly with internationalization frameworks. No other reflog
> > messages are translated right now and switching all the messages to
> > i18n would require a major rework of the way the messages are built.
>
> Thanks for spotting. Before we declare that reflog messages are for
> i18n, we'd need to either drop (or redesign the implementation of)
> the "checkout -" feature, which relies on the exact phrasing of how
> reflog entries from "git checkout" looks like.
>
> Will queue and merge down to 'master' quickly.
>
I didn't know this "side effect". Maybe adding a test against it would be
requiered. Unfortunately, I don't know enough of it.
next prev parent reply other threads:[~2017-05-03 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 10:02 [PATCH] i18n: remove i18n from tag reflog message Jean-Noel Avila
2017-04-30 21:32 ` [PATCH v2] i18n patches to apply for rc2 Jean-Noel Avila
2017-04-30 21:32 ` [PATCH v2 1/2] i18n: remove i18n from tag reflog message Jean-Noel Avila
2017-04-30 21:32 ` [PATCH v2 2/2] i18n: read-cache: Fix typo Jean-Noel Avila
2017-05-01 1:45 ` [PATCH] i18n: remove i18n from tag reflog message Junio C Hamano
2017-05-03 16:38 ` Jean-Noël AVILA [this message]
2017-05-04 1:35 ` Junio C Hamano
2017-05-04 1:38 ` Junio C Hamano
2017-05-01 9:15 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2070499.EYhsb04HyH@cayenne \
--to=jn.avila@free.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).