git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Beat Bolli <dev+git@drbeat.li>
To: <git@vger.kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Subject: [PATCH v3] gitk: Add a "Copy commit summary" command
Date: Fri, 17 Jul 2015 10:39:03 +0200	[thread overview]
Message-ID: <205a18f7f8a7892a1fa63a91a84bfd9b@drbeat.li> (raw)

When referring to earlier commits in commit messages or other text, one
of the established formats is

     <abbrev-sha> ("<summary>", <author-date>)

Add a "Copy commit summary" command to the context menu that puts this
text for the currently selected commit on the clipboard. This makes it
easy for our users to create well-formatted commit references.

The <abbrev-sha> is produced with the %h format specifier to make it
unique. Its minimum length can be controlled with the config setting
core.abbrev.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Johannes Sixt <j6t@kdbg.org>
Cc: Paul Mackerras <paulus@samba.org>

---
Changes since v2:
- call git log to produce a unique <abbrev-sha>
- use the short date format

Changes since v1:
- drop the "commit " literal in front of the <abbrev-sha>
---
  gitk-git/gitk | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index 9a2daf3..4915f53 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2617,6 +2617,7 @@ proc makewindow {} {
  	{mc "Diff selected -> this" command {diffvssel 1}}
  	{mc "Make patch" command mkpatch}
  	{mc "Create tag" command mktag}
+	{mc "Copy commit summary" command copysummary}
  	{mc "Write commit to file" command writecommit}
  	{mc "Create new branch" command mkbranch}
  	{mc "Cherry-pick this commit" command cherrypick}
@@ -9341,6 +9342,17 @@ proc mktaggo {} {
      mktagcan
  }

+proc copysummary {} {
+    global rowmenuid
+
+    set format "%h (\"%s\", %ad)"
+    set summary [exec git show -s --pretty=format:$format --date=short 
\
+                 $rowmenuid]
+
+    clipboard clear
+    clipboard append $summary
+}
+
  proc writecommit {} {
      global rowmenuid wrcomtop commitinfo wrcomcmd NS

-- 
2.4.0

             reply	other threads:[~2015-07-17  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17  8:39 Beat Bolli [this message]
2015-07-17 17:17 ` [PATCH v3] gitk: Add a "Copy commit summary" command Eric Sunshine
2015-07-17 17:28   ` Junio C Hamano
2015-07-17 20:59     ` Beat Bolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=205a18f7f8a7892a1fa63a91a84bfd9b@drbeat.li \
    --to=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).