git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
To: git@vger.kernel.org
Cc: xmqq1ph7u1sm.fsf@gitster.g
Subject: Re: What's cooking in git.git (Mar 2026, #10)
Date: Thu, 26 Mar 2026 02:41:30 +0530	[thread overview]
Message-ID: <20260325211240.1260690-1-shreyanshpaliwalcmsmn@gmail.com> (raw)

> Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:
>
> >> * sp/add-patch-with-fewer-the-repository (2026-03-17) 1 commit
> >>  - add-patch: use repository instance from add_i_state instead of the_repository
> >>
> >>  Reduce dependency on `the_repository` in add-patch.c file.
> >>
> >>  Needs review.
> >>  source: <20260317155230.619378-1-shreyanshpaliwalcmsmn@gmail.com>
> >
> > I think this was considered ready in the previous 'What's cooking in git.git',
> > so the status can be changed now.
>
> This was listed in the new topics section in issue #07 (Mar 19) but
> I do not recall updating its status in any later issue.  The only
> change was in issue #08 (Mar 21) in which the topic was moved from
> new to cooking without changing any status.
>
> The only comment the patch got was from me about interaction with
> other topics in flight, and there was no discussion or comments on
> what the patch wants to do makes sense, or if the way how the patch
> does so is correct, which should be the real review.
>
> And I do not consider my single reading alone a sufficient review
> most of the time.

Thanks for clarifying.
I might have misunderstood your earlier comment [1] as indicating that the
patch was good to go and had already reviewed.

[1]- https://lore.kernel.org/git/xmqqpl4v92eb.fsf@gitster.g/

Best,
Shreyansh


             reply	other threads:[~2026-03-25 21:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 21:11 Shreyansh Paliwal [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-25  4:20 What's cooking in git.git (Mar 2026, #10) Junio C Hamano
2026-03-25  6:13 ` Jeff King
2026-03-25  8:33 ` Shreyansh Paliwal
2026-03-25 19:50   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325211240.1260690-1-shreyanshpaliwalcmsmn@gmail.com \
    --to=shreyanshpaliwalcmsmn@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=xmqq1ph7u1sm.fsf@gitster.g \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).