From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Mirko Faina <mroik@delayed.space>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] t4014: fix call to `test_expect_success ()`
Date: Tue, 24 Mar 2026 15:52:30 +0100 [thread overview]
Message-ID: <20260324-b4-pks-t4014-fix-test-execution-v1-1-ac83c1bcc828@pks.im> (raw)
We have added a couple of new tests to t4014 in 6005932d95
(format-patch: add ability to use alt cover format, 2026-03-07). One of
the tests has typoed the call to `test_expect_success ()` and instead
invokes `test_expected_success ()`. Fix this.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
Hi,
this fixes a test bug in one of the new tests introduced via
"mf/format-patch-cover-letter-format". Thanks!
Patrick
---
t/t4014-format-patch.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 7c67bdf922..4f8967e283 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -393,7 +393,7 @@ test_expect_success 'cover letter with subject, author and count' '
test_line_count = 1 result
'
-test_expected_success 'cover letter with author and count' '
+test_expect_success 'cover letter with author and count' '
test_when_finished "git reset --hard HEAD~1" &&
test_when_finished "rm -rf patches result test_file" &&
touch test_file &&
---
base-commit: 927a571e75d06037d46dc9ef5fe26b0dc37bbff6
change-id: 20260324-b4-pks-t4014-fix-test-execution-b2fb17a880f9
next reply other threads:[~2026-03-24 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 14:52 Patrick Steinhardt [this message]
2026-03-24 15:18 ` [PATCH] t4014: fix call to `test_expect_success ()` Mirko Faina
2026-03-24 15:38 ` Junio C Hamano
2026-03-24 15:48 ` Mirko Faina
2026-03-24 16:39 ` Junio C Hamano
2026-03-24 17:13 ` Re* " Junio C Hamano
2026-03-24 18:05 ` [PATCH] t6002: make test "set -e" clean Junio C Hamano
2026-03-24 18:13 ` [PATCH] test-lib: catch misspelt 'test_expect_successo' Junio C Hamano
2026-03-24 19:35 ` Jeff King
2026-03-24 19:48 ` Junio C Hamano
2026-03-25 5:46 ` Jeff King
2026-03-24 18:20 ` [PATCH] t0008: make test "set -e" clean Junio C Hamano
2026-03-24 18:32 ` [PATCH] t7450: " Junio C Hamano
2026-03-24 18:38 ` Eric Sunshine
2026-03-24 19:03 ` Junio C Hamano
2026-03-25 7:07 ` Re* [PATCH] t4014: fix call to `test_expect_success ()` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324-b4-pks-t4014-fix-test-execution-v1-1-ac83c1bcc828@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mroik@delayed.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).