From: Mahi Kassa <mahlet.takassa@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, lucasseikioshiro@gmail.com, jltobler@gmail.com
Subject: [PATCH] repo: show subcommand-specific help text
Date: Mon, 23 Mar 2026 16:29:37 +0100 [thread overview]
Message-ID: <20260323152937.257406-1-mahlet.takassa@gmail.com> (raw)
Use subcommand-specific usage arrays for "git repo info" and "git repo structure" so that each command shows only its own synopsis in help output.
Keep the top-level "git repo -h" output unchanged, and add tests to cover the subcommand help behavior.
---
builtin/repo.c | 15 +++++++++++++--
t/t1900-repo-info.sh | 6 +++++-
t/t1901-repo-structure.sh | 5 +++++
3 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/builtin/repo.c b/builtin/repo.c
index 55f9b9095c..5ccc5c401a 100644
--- a/builtin/repo.c
+++ b/builtin/repo.c
@@ -27,6 +27,17 @@ static const char *const repo_usage[] = {
NULL
};
+static const char *const repo_info_usage[] = {
+ "git repo info [--format=(lines|nul) | -z] [--all | <key>...]",
+ "git repo info --keys [--format=(lines|nul) | -z]",
+ NULL
+};
+
+static const char *const repo_structure_usage[] = {
+ "git repo structure [--format=(table|lines|nul) | -z]",
+ NULL
+};
+
typedef int get_value_fn(struct repository *repo, struct strbuf *buf);
enum output_format {
@@ -214,7 +225,7 @@ static int cmd_repo_info(int argc, const char **argv, const char *prefix,
OPT_END()
};
- argc = parse_options(argc, argv, prefix, options, repo_usage, 0);
+ argc = parse_options(argc, argv, prefix, options, repo_info_usage, 0);
if (show_keys && (all_keys || argc))
die(_("--keys cannot be used with a <key> or --all"));
@@ -879,7 +890,7 @@ static int cmd_repo_structure(int argc, const char **argv, const char *prefix,
OPT_END()
};
- argc = parse_options(argc, argv, prefix, options, repo_usage, 0);
+ argc = parse_options(argc, argv, prefix, options, repo_structure_usage, 0);
if (argc)
usage(_("too many arguments"));
diff --git a/t/t1900-repo-info.sh b/t/t1900-repo-info.sh
index a9eb07abe8..e0e79ff167 100755
--- a/t/t1900-repo-info.sh
+++ b/t/t1900-repo-info.sh
@@ -148,5 +148,9 @@ test_expect_success 'git repo info --keys uses lines as its default output forma
git repo info --keys >actual &&
test_cmp expect actual
'
-
+test_expect_success 'git repo info -h shows only repo info usage' '
+ test_must_fail git repo info -h >actual &&
+ test_grep "git repo info" actual &&
+ test_grep ! "git repo structure" actual
+'
test_done
diff --git a/t/t1901-repo-structure.sh b/t/t1901-repo-structure.sh
index 98921ce1cb..0f7ec4da10 100755
--- a/t/t1901-repo-structure.sh
+++ b/t/t1901-repo-structure.sh
@@ -224,4 +224,9 @@ test_expect_success 'progress meter option' '
)
'
+test_expect_success 'git repo structure -h shows only repo structure usage' '
+ test_must_fail git repo structure -h >actual &&
+ test_grep "git repo structure" actual &&
+ test_grep ! "git repo info" actual
+'
test_done
--
2.34.1
next reply other threads:[~2026-03-23 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 15:29 Mahi Kassa [this message]
2026-03-23 19:32 ` [PATCH] repo: show subcommand-specific help text Derrick Stolee
2026-03-24 6:26 ` Patrick Steinhardt
2026-03-24 12:21 ` [PATCH v2] " Mahi Kassa
2026-03-24 12:52 ` Patrick Steinhardt
2026-03-24 17:07 ` Derrick Stolee
2026-03-24 18:48 ` [PATCH v3] " Mahi Kassa
2026-03-24 19:15 ` Derrick Stolee
2026-03-25 10:01 ` Patrick Steinhardt
2026-03-25 16:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323152937.257406-1-mahlet.takassa@gmail.com \
--to=mahlet.takassa@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=lucasseikioshiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).