From: Queen Ediri Jessa <qjessa662@gmail.com>
To: git@vger.kernel.org
Cc: christian.couder@gmail.com, usman.akinyemi@outlook.com,
QueenJcloud <qjessa662@gmail.com>
Subject: [PATCH v2] doc: clarify server behavior for invalid 'want' lines in HTTP protocol
Date: Tue, 4 Nov 2025 11:06:53 +0100 [thread overview]
Message-ID: <20251104100653.2152-1-qjessa662@gmail.com> (raw)
From: QueenJcloud <qjessa662@gmail.com>
From: Queen Ediri Jessa <qjessa662@gmail.com>
Update the documentation to clearly describe how the server responds when a
client sends an invalid or malformed `want` line during the HTTP protocol
exchange. This improves understanding of Git’s behavior when handling
incorrect object requests and helps developers detect and handle such
protocol issues accurately.
Signed-off-by: Queen Ediri Jessa <qjessa662@gmail.com>
Changes since v1:
- Rephrased the explanation to be more concise and aligned with reviewer
feedback.
- Clarified that the server includes the offending object name in its error
message.
- Adjusted tone to describe the expected behavior rather than prescribing
implementation-specific messages.
- Improved readability and technical consistency of the section.
---
Documentation/gitprotocol-http.adoc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/gitprotocol-http.adoc b/Documentation/gitprotocol-http.adoc
index d024010414..f3f48d3f35 100644
--- a/Documentation/gitprotocol-http.adoc
+++ b/Documentation/gitprotocol-http.adoc
@@ -443,7 +443,10 @@ If no "want" objects are received, send an error:
TODO: Define error if no "want" lines are requested.
If any "want" object is not reachable, send an error:
-TODO: Define error if an invalid "want" is requested.
+When a Git server receives an invalid or malformed `want` line, it
+responds with an error message that includes the offending object name.
+This clarifies the expected behavior for Git implementations and helps
+clients detect protocol issues accurately during fetch operations.
Create an empty list, `s_common`.
--
2.51.0.573.gb660e2dcb9
next reply other threads:[~2025-11-04 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 10:06 Queen Ediri Jessa [this message]
2025-11-04 14:35 ` [PATCH v2] doc: clarify server behavior for invalid 'want' lines in HTTP protocol Junio C Hamano
2025-11-04 15:17 ` Queen Ediri Jessa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104100653.2152-1-qjessa662@gmail.com \
--to=qjessa662@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=usman.akinyemi@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).