From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: Karthik Nayak <karthik.188@gmail.com>
Subject: [PATCH 0/5] maintenance: add an 'is-needed' subcommand
Date: Fri, 31 Oct 2025 15:22:20 +0100 [thread overview]
Message-ID: <20251031-562-add-sub-command-to-check-if-maintenance-is-needed-v1-0-a03d53e28d0e@gmail.com> (raw)
Hello,
I recently raised a patch series [1] to add 'git refs optimize --required'
which checks if the reference backend can be optimized, without actually
performing the optimization.
Back then, we had decided [2] that it would be a better to broaden the
approach and add a 'is-needed' subcommand to 'git-maintenance(1)'. This
would allow users to check if maintenance was required for the
repository and users could also provide a task via the '--task' to check
if maintenance was needed for a particular task.
Ideally the subcommand will be used with the '--auto' flag which can
check the same heuristics as that used with 'git maintenance run
--auto'. Future patches can also add support for the '--schedule' flag
which can be used to check required schedule it met. However that flag
isn't added as part of this series.
This series implements that.
Commits 1-3 add the required functionality in the refs subsystem to
expose an 'optimize_required' field which can be used to check if
backends need to be optimized.
Commit 4 utilizes this within the 'git-maintenance(1)' code.
Commit 5 adds the 'is-needed' subcommand to 'git-maintenance(1)'.
This is based on top of master a99f379adf (The 27th batch, 2025-10-30)
and is dependent on the following series:
- kn/refs-optim-cleanup
- ps/ref-peeled-tags
Merges cleanly with `next`. I think those two topics are close to being
merged to `next` so hopefully this dependency tree doesn't get too
complicated. I'll rebase as needed to resolve conflicts.
[1]: https://lore.kernel.org/git/20251010-562-add-option-to-check-if-reference-backend-needs-repacking-v1-0-c7962be584fa@gmail.com/
[2]: https://lore.kernel.org/git/CAOLa=ZRdxm787nE4FSr2VUHDB+hW06Ggc6yUcKmeTKAb6B7YOA@mail.gmail.com/
---
Documentation/git-maintenance.adoc | 8 ++++
builtin/gc.c | 86 +++++++++++++++++++++++++++++++++-----
object.h | 1 -
refs.c | 7 ++++
refs.h | 7 ++++
refs/debug.c | 13 ++++++
refs/files-backend.c | 11 +++++
refs/packed-backend.c | 13 ++++++
refs/refs-internal.h | 6 +++
refs/reftable-backend.c | 25 +++++++++++
reftable/reftable-stack.h | 5 +++
reftable/stack.c | 48 ++++++++++++++++-----
t/t7900-maintenance.sh | 54 +++++++++++++++++-------
t/unit-tests/u-reftable-stack.c | 12 +++++-
14 files changed, 256 insertions(+), 40 deletions(-)
Karthik Nayak (5):
reftable/stack: return stack segments directly
reftable/stack: add function to check if optimization is required
refs: add a `optimize_required` field to `struct ref_storage_be`
maintenance: add checking logic in `pack_refs_condition()`
maintenance: add 'is-needed' subcommand
base-commit: edd2018f5db39d68d55a7a4af42375b1a06b9406
change-id: 20251021-562-add-sub-command-to-check-if-maintenance-is-needed-01cae01b4606
Thanks
- Karthik
next reply other threads:[~2025-10-31 14:22 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 14:22 Karthik Nayak [this message]
2025-10-31 14:22 ` [PATCH 1/5] reftable/stack: return stack segments directly Karthik Nayak
2025-10-31 16:22 ` Justin Tobler
2025-11-03 15:05 ` Karthik Nayak
2025-11-03 18:03 ` Justin Tobler
2025-10-31 14:22 ` [PATCH 2/5] reftable/stack: add function to check if optimization is required Karthik Nayak
2025-10-31 17:02 ` Justin Tobler
2025-10-31 18:17 ` Junio C Hamano
2025-11-03 16:20 ` Karthik Nayak
2025-11-03 15:51 ` Karthik Nayak
2025-11-03 17:59 ` Justin Tobler
2025-11-03 14:00 ` Patrick Steinhardt
2025-11-03 16:35 ` Karthik Nayak
2025-10-31 14:22 ` [PATCH 3/5] refs: add a `optimize_required` field to `struct ref_storage_be` Karthik Nayak
2025-10-31 14:22 ` [PATCH 4/5] maintenance: add checking logic in `pack_refs_condition()` Karthik Nayak
2025-11-03 14:00 ` Patrick Steinhardt
2025-11-03 17:04 ` Karthik Nayak
2025-10-31 14:22 ` [PATCH 5/5] maintenance: add 'is-needed' subcommand Karthik Nayak
2025-11-03 14:00 ` Patrick Steinhardt
2025-11-03 17:18 ` Karthik Nayak
2025-11-04 5:54 ` Patrick Steinhardt
2025-11-04 8:28 ` Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 0/5] maintenance: add an " Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 1/5] reftable/stack: return stack segments directly Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 2/5] reftable/stack: add function to check if optimization is required Karthik Nayak
2025-11-04 20:26 ` Junio C Hamano
2025-11-05 14:11 ` Karthik Nayak
2025-11-05 18:10 ` Junio C Hamano
2025-11-06 8:18 ` Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 3/5] refs: add a `optimize_required` field to `struct ref_storage_be` Karthik Nayak
2025-11-04 8:43 ` [PATCH v2 4/5] maintenance: add checking logic in `pack_refs_condition()` Karthik Nayak
2025-11-04 8:44 ` [PATCH v2 5/5] maintenance: add 'is-needed' subcommand Karthik Nayak
2025-11-04 15:43 ` [PATCH v2 0/5] maintenance: add an " Junio C Hamano
2025-11-05 14:00 ` Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 " Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 1/5] reftable/stack: return stack segments directly Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 2/5] reftable/stack: add function to check if optimization is required Karthik Nayak
2025-11-06 18:18 ` Junio C Hamano
2025-11-07 6:06 ` Patrick Steinhardt
2025-11-06 8:22 ` [PATCH v3 3/5] refs: add a `optimize_required` field to `struct ref_storage_be` Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 4/5] maintenance: add checking logic in `pack_refs_condition()` Karthik Nayak
2025-11-06 11:58 ` Patrick Steinhardt
2025-11-06 13:04 ` Karthik Nayak
2025-11-06 15:24 ` Junio C Hamano
2025-11-07 15:58 ` Karthik Nayak
2025-11-07 16:41 ` Junio C Hamano
2025-11-07 15:58 ` Karthik Nayak
2025-11-06 8:22 ` [PATCH v3 5/5] maintenance: add 'is-needed' subcommand Karthik Nayak
2025-11-06 12:02 ` Patrick Steinhardt
2025-11-06 13:07 ` Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 0/5] maintenance: add an " Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 1/5] reftable/stack: return stack segments directly Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 2/5] reftable/stack: add function to check if optimization is required Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 3/5] refs: add a `optimize_required` field to `struct ref_storage_be` Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 4/5] maintenance: add checking logic in `pack_refs_condition()` Karthik Nayak
2025-11-08 21:51 ` [PATCH v4 5/5] maintenance: add 'is-needed' subcommand Karthik Nayak
2025-11-10 6:46 ` [PATCH v4 0/5] maintenance: add an " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031-562-add-sub-command-to-check-if-maintenance-is-needed-v1-0-a03d53e28d0e@gmail.com \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).