From: Maxim Cournoyer <maxim@guixotic.coop>
To: git@vger.kernel.org
Cc: Maxim Cournoyer <maxim@guixotic.coop>
Subject: [PATCH] contrib: Honor symbolic port in git-credential-netrc.
Date: Fri, 20 Jun 2025 13:12:39 +0900 [thread overview]
Message-ID: <20250620041239.27839-1-maxim@guixotic.coop> (raw)
Symbolic ports were previously silently dropped, which made it
impossible to use them with git-credential-netrc. This is a supported
use case according to 'man git-send-email', for --smtp-server-port:
[...] symbolic port names (e.g. "submission" instead of 587) are
also accepted.
---
contrib/credential/netrc/git-credential-netrc.perl | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/contrib/credential/netrc/git-credential-netrc.perl b/contrib/credential/netrc/git-credential-netrc.perl
index 9fb998ae09..ad06000b9f 100755
--- a/contrib/credential/netrc/git-credential-netrc.perl
+++ b/contrib/credential/netrc/git-credential-netrc.perl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/env perl
use strict;
use warnings;
@@ -267,7 +267,9 @@ sub load_netrc {
if (!defined $nentry->{machine}) {
next;
}
- if (defined $nentry->{port} && $nentry->{port} =~ m/^\d+$/) {
+ if (defined $nentry->{port} && $nentry->{port} =~ m/^[[:alnum:]]+$/) {
+ # Port may be either an integer or a symbolic
+ # name, e.g. "smtps".
$num_port = $nentry->{port};
delete $nentry->{port};
}
base-commit: 9520f7d9985d8879bddd157309928fc0679c8e92
--
2.49.0
next reply other threads:[~2025-06-20 4:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 4:12 Maxim Cournoyer [this message]
2025-06-20 13:48 ` [PATCH] contrib: Honor symbolic port in git-credential-netrc Junio C Hamano
2025-06-20 14:22 ` Andreas Schwab
2025-06-20 16:39 ` Junio C Hamano
2025-06-21 13:57 ` Maxim Cournoyer
2025-06-23 3:28 ` Maxim Cournoyer
2025-06-23 3:34 ` Maxim Cournoyer
2025-06-20 19:03 ` brian m. carlson
2025-06-21 13:29 ` Maxim Cournoyer
2025-06-21 15:52 ` brian m. carlson
2025-06-22 15:25 ` [PATCH v2 0/3] git-credential-netrc: better symbolic port names support Maxim Cournoyer
2025-06-22 15:25 ` [PATCH v2 1/3] contrib: use a more portable shebang for git-credential-netrc Maxim Cournoyer
2025-06-22 15:25 ` [PATCH v2 2/3] contrib: warn for invalid netrc file ports in git-credential-netrc Maxim Cournoyer
2025-06-22 15:25 ` [PATCH v2 3/3] contrib: better support symbolic port names " Maxim Cournoyer
2025-06-23 18:03 ` Junio C Hamano
2025-06-24 1:51 ` Maxim Cournoyer
2025-06-24 1:48 ` [PATCH v3 0/3] git-credential-netrc: better symbolic port names support Maxim Cournoyer
2025-06-24 16:04 ` Junio C Hamano
2025-06-24 23:55 ` Maxim Cournoyer
2025-06-25 0:24 ` Junio C Hamano
2025-06-25 1:03 ` Maxim Cournoyer
2025-06-25 14:25 ` [PATCH v4 " Maxim Cournoyer
2025-06-25 14:25 ` [PATCH v4 1/3] contrib: use a more portable shebang for git-credential-netrc Maxim Cournoyer
2025-06-25 14:25 ` [PATCH v4 2/3] contrib: warn for invalid netrc file ports in git-credential-netrc Maxim Cournoyer
2025-06-25 14:25 ` [PATCH v4 3/3] contrib: better support symbolic port names " Maxim Cournoyer
2025-06-25 16:49 ` [PATCH v4 0/3] git-credential-netrc: better symbolic port names support Junio C Hamano
2025-06-26 1:15 ` Maxim Cournoyer
2025-06-24 1:48 ` [PATCH v3 1/3] contrib: use a more portable shebang for git-credential-netrc Maxim Cournoyer
2025-06-24 1:48 ` [PATCH v3 2/3] contrib: warn for invalid netrc file ports in git-credential-netrc Maxim Cournoyer
2025-06-24 1:48 ` [PATCH v3 3/3] contrib: better support symbolic port names " Maxim Cournoyer
2025-06-24 16:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620041239.27839-1-maxim@guixotic.coop \
--to=maxim@guixotic.coop \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).