From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git@vger.kernel.org
Subject: Re: t4216-log-bloom.sh broken ?
Date: Thu, 2 May 2024 22:51:21 +0200 [thread overview]
Message-ID: <20240502205121.GB11895@tb-raspi4> (raw)
In-Reply-To: <xmqqsez0c6ma.fsf@gitster.g>
On Thu, May 02, 2024 at 01:15:57PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > I am curious what other differences Torsten will find out between
> > good macs and bad ones. Perhaps we can narrow down the bad apples?
>
> So, "no, your 'mv' is broken" seems to be the answer to the question
> on the Subject line, and it is rather well-known, it seems.
[]
> "$@" <"$fn" >"$fn.tmp" &&
> - mv "$fn.tmp" "$fn"
> + # some vintages of macOS 'mv' fails to overwrite a read-only file.
> + mv -f "$fn.tmp" "$fn"
Thanks folks for digging - the patch makes both test cases pass.
Some official information:
$ man mv
on the both machines says
[snip]
If the destination path does not have a mode which permits writing,
mv prompts the user for confirmation as specified for the -i option.
To summarize what I have at hand right now:
MacOs 11.7.10 fails t4216 and t5318, both pass under MacOs 13.6.6
But why doesn't `mv` not hang then ?
next prev parent reply other threads:[~2024-05-02 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 17:12 [ANNOUNCE] Git v2.45.0 Junio C Hamano
2024-05-01 17:39 ` rsbecker
2024-05-02 5:56 ` t4216-log-bloom.sh broken ? Torsten Bögershausen
2024-05-02 16:06 ` Junio C Hamano
2024-05-02 18:59 ` Torsten Bögershausen
2024-05-02 19:26 ` SZEDER Gábor
2024-05-02 19:55 ` Junio C Hamano
2024-05-02 20:05 ` Junio C Hamano
2024-05-02 20:15 ` Junio C Hamano
2024-05-02 20:51 ` Torsten Bögershausen [this message]
2024-05-02 21:20 ` Junio C Hamano
2024-05-02 16:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502205121.GB11895@tb-raspi4 \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).