From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 253721F44D for ; Wed, 27 Mar 2024 07:52:54 +0000 (UTC) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E568EB23073 for ; Wed, 27 Mar 2024 07:52:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3CF9E2C85C; Wed, 27 Mar 2024 07:47:06 +0000 (UTC) Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13E322C850 for ; Wed, 27 Mar 2024 07:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=104.130.231.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711525625; cv=none; b=CoSDNizjUAWdeQ9qOSOMAMZmLURUG8WWnqLcA7GpfpvJm4H9lx1Ea92chvkiXSwycpGi217p2fEJGgwtIy2uaPWZWc/NgpQ5NNOokBInHM664RZcvgjKiCp+hosyGEtihPcyrs0w51NXdzRqE1m5AHgNJ1FLNtkBzXib+7poGfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711525625; c=relaxed/simple; bh=6DKfkwO0LofFTdcufzfZjSn+ecBtTDPpfCkLpT1LakY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K66P+HYRNWFlQKLD481yJWx/vfIr8CC+avzLQIDbZ033xRNAi5yH5FxK09k70nrDaJXAH5rntp4XCwOyH4l0GTYI+L3J7h3y235g4zlYn8WJD6oT2D9LMnRD+g7Q1YlLppwFBKCNz7DzJEg8EaXKjbpU9J/xDJ+kDicsK7hBP/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=peff.net; spf=pass smtp.mailfrom=peff.net; arc=none smtp.client-ip=104.130.231.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=peff.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peff.net Received: (qmail 19842 invoked by uid 109); 27 Mar 2024 07:46:55 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 27 Mar 2024 07:46:55 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 24083 invoked by uid 111); 27 Mar 2024 07:47:00 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 27 Mar 2024 03:47:00 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 27 Mar 2024 03:46:55 -0400 From: Jeff King To: Junio C Hamano Cc: Kristoffer Haugsbakk , Dragan Simic , Manlio Perillo , =?utf-8?B?UmVuw6k=?= Scharfe , Phillip Wood , git@vger.kernel.org Subject: Re: [PATCH v2 16/16] config: allow multi-byte core.commentChar Message-ID: <20240327074655.GA831122@coredump.intra.peff.net> References: <20240312091013.GA95442@coredump.intra.peff.net> <20240312091750.GP95609@coredump.intra.peff.net> <0426f7bf-6032-4fc7-886c-c4278c6e105b@app.fastmail.com> <20240315055944.GB1741107@coredump.intra.peff.net> <6be335ed-8598-406c-b535-2e58554b00e9@app.fastmail.com> <20240315081041.GA1753560@coredump.intra.peff.net> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Mar 26, 2024 at 03:10:23PM -0700, Junio C Hamano wrote: > It has been 10 days since this discussion petered out. I wrote the last message, so I was waiting for you to respond. ;) https://lore.kernel.org/git/20240316055013.GA32145@coredump.intra.peff.net/ > My preference is to introduce core.commentString to avoid confusion > coming from an older Git using the first-byte of a multi-byte > string, or dying upon reading a configuration file meant for a newer > Git, and then let core.commentString override core.commentChar, but > I would prefer to see the discussion participants to raise their > opinions and reach a conclusion. OK. I don't have a strong opinion. Are you OK with core.commentString as a strict synonym (so last-one-wins and either name overwrites previous)? Or do you want an override (i.e., commentString always overrides commentChar, regardless of order). I think it's mostly academic, and the strict synonym version is much easier to implement. -Peff