From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 139.178.88.0/22 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5BE2E1F44D for ; Tue, 12 Mar 2024 09:22:01 +0000 (UTC) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3EE3A286482 for ; Tue, 12 Mar 2024 09:22:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 46B897C6F6; Tue, 12 Mar 2024 09:17:51 +0000 (UTC) Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7DF7C0B3 for ; Tue, 12 Mar 2024 09:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=104.130.231.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710235070; cv=none; b=GkRxmRkLfm6oJauG34qfwiaBaDNLiUhg7yznXrdg/loJ88xusyUjHKOHX80mrHpRwNLEn0QBqWQJSGT9kMQLNBjNFn4DBs+tr+ZiY3uY8wj8eTOenauV/wIGh3uM2wytxe7X3zyJGs+zKgUusN2+gpwkFWEvip52WSOFCQDe/u0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710235070; c=relaxed/simple; bh=dE+OgkC6uDx74Un+L8u26xa5OYAByAmeNrMfhV/nnAI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FutwrmqmdFzcyOD2Jm12/semRSY2i1UtDxRkgyYQDoWOArZymNLKWAZ5i3VByXg9XbB0T5sQ/gqzvxW4W4iO0QZUTh1oND6qhNfL6J+uX5SQCnnTCb7U7z5UpALOLTImXbUFEAzqYK68YBpLUkfqysdYdtR1leGgz7fpHlwoW/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=peff.net; spf=pass smtp.mailfrom=peff.net; arc=none smtp.client-ip=104.130.231.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=peff.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peff.net Received: (qmail 17725 invoked by uid 109); 12 Mar 2024 09:17:49 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 12 Mar 2024 09:17:49 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 28126 invoked by uid 111); 12 Mar 2024 09:17:53 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 12 Mar 2024 05:17:53 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 12 Mar 2024 05:17:47 -0400 From: Jeff King To: git@vger.kernel.org Cc: Junio C Hamano , Dragan Simic , Kristoffer Haugsbakk , Manlio Perillo , =?utf-8?B?UmVuw6k=?= Scharfe , Phillip Wood Subject: [PATCH v2 15/16] environment: drop comment_line_char compatibility macro Message-ID: <20240312091747.GO95609@coredump.intra.peff.net> References: <20240312091013.GA95442@coredump.intra.peff.net> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240312091013.GA95442@coredump.intra.peff.net> There is no longer any code which references the single-byte comment_line_char. Let's drop it, clearing the way for true multi-byte entries in comment_line_str. It's possible there are topics in flight that have added new references to comment_line_char. But we would prefer to fail compilation (and then fix it) upon merging with this, rather than have them quietly ignore the bytes after the first. Signed-off-by: Jeff King --- environment.h | 1 - 1 file changed, 1 deletion(-) diff --git a/environment.h b/environment.h index 1c7d0c2f74..05fd94d7be 100644 --- a/environment.h +++ b/environment.h @@ -8,7 +8,6 @@ struct strvec; * The character that begins a commented line in user-editable file * that is subject to stripspace. */ -#define comment_line_char (comment_line_str[0]) extern const char *comment_line_str; extern int auto_comment_line_char; -- 2.44.0.481.gf1a6d20963