From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3E0FC1F44D for ; Wed, 6 Mar 2024 00:51:10 +0000 (UTC) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D2CE81F2753C for ; Wed, 6 Mar 2024 00:51:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18AC0C8C7; Wed, 6 Mar 2024 00:51:02 +0000 (UTC) Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45FF16FAD for ; Wed, 6 Mar 2024 00:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=104.130.231.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709686261; cv=none; b=fm5FqPsaDNkQ7YA4WzG6H/4j/iMMHz7UM7Y+ZZWEvRoZuQilZ/pnEgcpShHq27UsvoPoxvFb0Vg4yzpl2Fxu9aDYX3gUjvfqvXTXvAzQ2o/Qf9Ma4Lmv6RENBp0vp4dXBIqZ3d2a5Cv1KRZmsX6LNEgffzDIHWLhh6VZkxxcdcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709686261; c=relaxed/simple; bh=/ipYmJuJR00ZMBgamAKas6jSIQpVRi2i+def8czA5xQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=isr8Q0H91m8qNqYOWPIXkEnEx8RjXSM8ef+BrlYZRiiK7vHINqshlf7OJRzalzYiaPxZAVng22AOA7ypfkAT4OYMEsS39aunymtEkrW4cpC7KgitPs7dZ5VReJ33eLj1SI/NCBARVH/VQbWgmYy1Ejcw1BZOg6WwVsb310vtBbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=peff.net; spf=pass smtp.mailfrom=peff.net; arc=none smtp.client-ip=104.130.231.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=peff.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peff.net Received: (qmail 22618 invoked by uid 109); 6 Mar 2024 00:50:58 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 06 Mar 2024 00:50:58 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 30292 invoked by uid 111); 6 Mar 2024 00:51:00 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 05 Mar 2024 19:51:00 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 5 Mar 2024 19:50:57 -0500 From: Jeff King To: Josh Steadmon Cc: git@vger.kernel.org Subject: Re: [PATCH 1/2] ci: also define CXX environment variable Message-ID: <20240306005057.GC3797463@coredump.intra.peff.net> References: <75f98cbf98005b0a069977096ec5501f2f7830fe.1709673020.git.steadmon@google.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <75f98cbf98005b0a069977096ec5501f2f7830fe.1709673020.git.steadmon@google.com> On Tue, Mar 05, 2024 at 01:11:59PM -0800, Josh Steadmon wrote: > In a future commit, we will build the fuzzer executables as part of the > default 'make all' target, which requires a C++ compiler. If we do not > explicitly set CXX, it defaults to g++ on GitHub CI. However, this can > lead to incorrect feature detection when CC=clang, since the > 'detect-compiler' script only looks at CC. Fix the issue by always > setting CXX to match CC in our CI config. > > We only plan on building fuzzers on Linux, so none of the other CI > configs need a similar adjustment. Does this mean that after your patch 2, running: make CC=clang may have problems on Linux, because it will now try to link fuzzers using g++, even though everything else is built with clang (and ditto the detect-compiler used it)? -Peff