From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, git-packagers@googlegroups.com,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [ANNOUNCE] Git v2.44.0
Date: Sat, 24 Feb 2024 14:10:40 +0900 [thread overview]
Message-ID: <20240224051040.ftuo24smozqugbde@glandium.org> (raw)
In-Reply-To: <xmqqbk87w164.fsf@gitster.g>
Hi,
On Fri, Feb 23, 2024 at 09:17:07AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt (139):
> builtin/clone: create the refdb with the correct object format
I haven't analyzed how/why exactly yet, but I've bisected a regression
in the behavior of is_git_directory() during a clone to originate from
this change.
Here's a way to reproduce the problem:
```
$ cat > git-remote-foo <<EOF
#!/bin/sh
git config --local -l >&2
exit 1
EOF
$ chmod +x git-remote-foo
$ PATH=$PWD:$PATH git clone foo::bar
```
With versions < 2.44.0, it displays the local configuration, e.g.:
```
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=foo::bar
```
but with 2.44.0, it fails with:
```
fatal: --local can only be used inside a git repository
```
Mike
next prev parent reply other threads:[~2024-02-24 5:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 17:17 [ANNOUNCE] Git v2.44.0 Junio C Hamano
2024-02-24 5:10 ` Mike Hommey [this message]
2024-02-24 6:36 ` Patrick Steinhardt
2024-02-24 19:55 ` Mike Hommey
2024-02-25 7:09 ` Patrick Steinhardt
2024-02-25 17:16 ` Junio C Hamano
2024-02-27 7:02 ` Patrick Steinhardt
2024-02-27 14:29 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240224051040.ftuo24smozqugbde@glandium.org \
--to=mh@glandium.org \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).