From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: commit-graph paranoia performance, was Re: [ANNOUNCE] Git v2.43.0-rc1
Date: Tue, 14 Nov 2023 04:05:06 -0500 [thread overview]
Message-ID: <20231114090506.GA2107135@coredump.intra.peff.net> (raw)
In-Reply-To: <ZVMz4iDWfC__H8Jp@tanuki>
On Tue, Nov 14, 2023 at 09:46:26AM +0100, Patrick Steinhardt wrote:
> > Should we default GIT_COMMIT_GRAPH_PARANOIA to "0"? Yes, some operations
> > might miss a breakage, but that is true of so much of Git. For day to
> > day commands we generally assume that the repository is not corrupted,
> > and avoid looking at any data we can. Other commands (like "commit-graph
> > verify", but maybe others) would probably want to be more careful
> > (either by checking this case explicitly, or by enabling the paranoia
> > flag themselves).
>
> I'd be fine with that as a follow-up change, yes. I agree that in
> general we shouldn't see this kind of corruption, and it's good that the
> behaviour can be toggled so easily now.
>
> I'm happy to write that patch if you don't plan to.
I hadn't started on it, so please feel free to go ahead.
-Peff
prev parent reply other threads:[~2023-11-14 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 17:33 [ANNOUNCE] Git v2.43.0-rc1 Junio C Hamano
2023-11-10 7:59 ` Andy Koppe
2023-11-13 20:55 ` commit-graph paranoia performance, was " Jeff King
2023-11-13 23:50 ` Junio C Hamano
2023-11-14 8:46 ` Patrick Steinhardt
2023-11-14 9:05 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114090506.GA2107135@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).