From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-11.3 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 175EA1F55F for ; Tue, 19 Sep 2023 22:59:34 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=14Hd4NPy; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232038AbjISW7g (ORCPT ); Tue, 19 Sep 2023 18:59:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjISW7f (ORCPT ); Tue, 19 Sep 2023 18:59:35 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D361C4 for ; Tue, 19 Sep 2023 15:59:29 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d77fa2e7771so6698958276.1 for ; Tue, 19 Sep 2023 15:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695164368; x=1695769168; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=fEUOifDaHuMxeqQKtr9g0z2GTtz5EeTtKXmf1UEBuro=; b=14Hd4NPy02oQha9TF5b2guxWTfx2r4EWAbK1g3soswcjLmtzaBm7Em3+5QTQhwyayK aIyn7xP+UjZ/284KKFp41/NMGsncymf3nohKwVfKvl3zNoYpc2vgOFXrx3J8Zx8GOJ6x BBJLJ/abm37LEELU0pdDFtuY6WwhPfbwcg2qZ75y6TN0YhW7KYXMsy/TOAZnJWutiXIj WJBaP5j50fRkUlMvejLyhxB5olplpelI9Wm6kBgPtuwpUb2VoxmEtInVIy/iqdXSjIvc K2idpqmto3gUr+O5mcS4Rr8+gp31gNakPgKAepNDU71ZmNukeSrgks6ZVsycxW9s7WEZ IAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695164368; x=1695769168; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fEUOifDaHuMxeqQKtr9g0z2GTtz5EeTtKXmf1UEBuro=; b=qRdqk39oVj2laFoFY2fgKJIQU1LFtYVkJ//9P95NBY3GjgKy7znxuNZVSUMfYHATuN YVyHyxmJvILYCF4HPeJlKvZyY+Rm1I2bWtxpergyTUEToo+DcxMi1LPEs0qbNlrWseEc 2ozQcPzELHhZrvHUD1E7IBBTiq/HGFEfPfGHqaYUtrBsLhb4MeuaLa2k54Uqj2SXBhPB oTFO8i7cxuGIMIgvQrF2cGgCY8QRttQZcTD1Lq2whzNJYPIgOrdQYm1JSYHy0yVMDXDs ffODi8pej0tIgT5Rgt51RMezpVHl4O1rqZQO7ED3bnCMvpKBnV73Z4wb9SMirfzy0lDK bKTw== X-Gm-Message-State: AOJu0YyjZVLi7/nLU++M1jgerrPcjhJ/fSlWLTMdI55aWsS6VrVIGxBB J8BemuTsc/gd/fzSSUPN1Fcv/x0F2Xo/W2BUIy1W X-Google-Smtp-Source: AGHT+IFUN9uJ8kVwyJPaI1sSglWhNKiZDKNGP163eYoiNWZBW9nmPxDBgBRhaYimQricfeSzswoKM6f+VF/kGtp+kHt0 X-Received: from jonathantanmy0.svl.corp.google.com ([2620:15c:2d3:204:def5:f709:d6a:7375]) (user=jonathantanmy job=sendgmr) by 2002:a05:6902:140e:b0:d81:9903:9dec with SMTP id z14-20020a056902140e00b00d8199039decmr13696ybu.7.1695164368403; Tue, 19 Sep 2023 15:59:28 -0700 (PDT) Date: Tue, 19 Sep 2023 15:59:26 -0700 In-Reply-To: <0b9525db5a0787fdc71834abad9151aa03acc497.1694125210.git.gitgitgadget@gmail.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.459.ge4e396fd5e-goog Message-ID: <20230919225926.2189091-1-jonathantanmy@google.com> Subject: Re: [PATCH v3 13/13] trailer doc: is a or , not both From: Jonathan Tan To: Linus Arver via GitGitGadget Cc: Jonathan Tan , git@vger.kernel.org, Christian Couder , Linus Arver Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Linus Arver via GitGitGadget" writes: > @@ -248,34 +258,40 @@ With `add`, a new trailer will be added. > + > With `doNothing`, nothing will be done. > > -trailer..key:: > - This `key` will be used instead of in the trailer. At > - the end of this key, a separator can appear and then some > - space characters. By default the only valid separator is ':', > - but this can be changed using the `trailer.separators` config > - variable. > +trailer..key:: > + Defines a for the . The must be a > + prefix (case does not matter) of the . For example, in `git > + config trailer.ack.key "Acked-by"` the "Acked-by" is the and > + the "ack" is the . This configuration allows the shorter > + `--trailer "ack:..."` invocation on the command line using the "ack" > + instead of the longer `--trailer "Acked-by:..."`. > ++ > +At the end of the , a separator can appear and then some > +space characters. By default the only valid separator is ':', > +but this can be changed using the `trailer.separators` config > +variable. I think all the other patches will be a great help to the user, but I'm on the fence about this one. Someone who knows these trailer components by their old names might be confused upon seeing tne new ones, so I'm inclined to minimize such changes. I do think that the new names make more sense, though. The documentation doesn't seem to say what happens when trailer.ack.cmd and trailer.Acked-by.cmd (replace "cmd" with whatever) are defined, but that was true previously too (and knowing this does not really enable the user to be able to do something they previously couldn't, so this is fine).