From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Teng Long" <dyroneteng@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 1/3] leak tests: mark a handful of tests as leak-free
Date: Thu, 24 Aug 2023 17:02:38 -0400 [thread overview]
Message-ID: <20230824210238.GA940724@coredump.intra.peff.net> (raw)
In-Reply-To: <b1711c4c817f95011bc477a9485c115b4926c7da.1692902414.git.me@ttaylorr.com>
On Thu, Aug 24, 2023 at 02:40:38PM -0400, Taylor Blau wrote:
> In the topic merged via 5a4f8381b6 (Merge branch
> 'ab/mark-leak-free-tests', 2021-10-25), a handful of tests in the suite
> were marked as leak-free.
>
> As far as I can tell, each patch from that series ran tests from a
> handful of subject areas, such as "some ls-files tests", or "all trace2
> tests". This left some gaps in which tests had and hadn't been audited
> to be leak-free.
>
> This patch closes those gaps by exporting TEST_PASSES_SANITIZE_LEAK=true
> before sourcing t/test-lib.sh on most remaining leak-free tests. This
> list was compiled by doing:
>
> $ make SANITIZE=leak
> $ make \
> GIT_TEST_PASSING_SANITIZE_LEAK=check \
> GIT_TEST_SANITIZE_LEAK_LOG=true \
> GIT_TEST_OPTS=-vi test
So having resolved my "oops, lsan logs are racy" problem, my system now
agrees with yours on which tests are now leak-free. And we definitely
_were_ leak free less than year ago when I posted that other patch. So
I'm not sure I buy the "these were missed in 5a4f8381b6" logic.
The one in t5571, I mentioned earlier that I bisected to 861c56f6f9
(branch: fix a leak in setup_tracking, 2023-06-11).
The one in t7516 seems to have been fixed by 866b43e644
(do_read_index(): always mark index as initialized unless erroring out,
2023-06-29).
I found both by bisecting between v2.39.0 (which shows the leak) and
v2.42.0 (which doesn't).
-Peff
next prev parent reply other threads:[~2023-08-24 21:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 18:40 [PATCH 0/3] leak tests: mark remaining tests leak-free as such Taylor Blau
2023-08-24 18:40 ` [PATCH 1/3] leak tests: mark a handful of tests as leak-free Taylor Blau
2023-08-24 21:02 ` Jeff King [this message]
2023-08-25 19:05 ` Taylor Blau
2023-08-25 20:38 ` Jeff King
2023-08-28 18:24 ` Junio C Hamano
2023-08-28 18:37 ` [PATCH] test-lib: ignore uninteresting LSan output Jeff King
2023-08-24 18:40 ` [PATCH 2/3] leak tests: mark t3321-notes-stripspace.sh as leak-free Taylor Blau
2023-08-24 18:40 ` [PATCH 3/3] leak tests: mark t5583-push-branches.sh " Taylor Blau
2023-08-24 18:50 ` [PATCH 0/3] leak tests: mark remaining tests leak-free as such Junio C Hamano
2023-08-24 20:50 ` Jeff King
2023-08-24 20:54 ` Jeff King
2023-08-25 19:08 ` Taylor Blau
2023-08-25 20:35 ` Jeff King
2023-08-28 22:52 ` [PATCH v2 0/4] " Taylor Blau
2023-08-28 22:52 ` [PATCH v2 1/4] test-lib: ignore uninteresting LSan output Taylor Blau
2023-08-28 22:52 ` [PATCH v2 2/4] leak tests: mark a handful of tests as leak-free Taylor Blau
2023-08-28 22:53 ` [PATCH v2 3/4] leak tests: mark t3321-notes-stripspace.sh " Taylor Blau
2023-08-28 22:53 ` [PATCH v2 4/4] leak tests: mark t5583-push-branches.sh " Taylor Blau
2023-08-29 1:00 ` [PATCH v2 0/4] leak tests: mark remaining tests leak-free as such Jeff King
2023-08-29 16:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824210238.GA940724@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).