From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 0EBFA1F545 for ; Mon, 3 Jul 2023 06:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230051AbjGCG33 (ORCPT ); Mon, 3 Jul 2023 02:29:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjGCG31 (ORCPT ); Mon, 3 Jul 2023 02:29:27 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3C2EBA for ; Sun, 2 Jul 2023 23:29:26 -0700 (PDT) Received: (qmail 12457 invoked by uid 109); 3 Jul 2023 06:29:27 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 03 Jul 2023 06:29:27 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 2494 invoked by uid 111); 3 Jul 2023 06:29:29 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 03 Jul 2023 02:29:29 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 3 Jul 2023 02:29:25 -0400 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, Chris Torek , Derrick Stolee , Junio C Hamano , Patrick Steinhardt Subject: Re: [PATCH v4 00/16] refs: implement jump lists for packed backend Message-ID: <20230703062925.GK3502534@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jun 20, 2023 at 10:20:51AM -0400, Taylor Blau wrote: > Here is another reroll of my series to implement jump (née skip) lists > for the packed refs backend, based on top of the current 'master'. > > Most changes are minor, limited to changing variable names, moving > changes around between patches and tweaking commit messages for clarity. > I think that the first 9 or so patches are stable, but we may want some > more eyes on the remainder. I had been avoiding reading this series too carefully, as I was involved in many of the early patches. But now it's been long enough that I mostly forgot everything, so I could look at it with fresh eyes. ;) Plus the hidden-refs bits at the end were totally new to me. It looks good to me overall. I left a few small comments, some of which I think probably justify a re-roll. -Peff