From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 2FB881F542 for ; Thu, 18 May 2023 18:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbjERS2l (ORCPT ); Thu, 18 May 2023 14:28:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjERS2k (ORCPT ); Thu, 18 May 2023 14:28:40 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 076041B5 for ; Thu, 18 May 2023 11:28:39 -0700 (PDT) Received: (qmail 1210 invoked by uid 109); 18 May 2023 18:28:39 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 18 May 2023 18:28:39 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23381 invoked by uid 111); 18 May 2023 18:28:38 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 18 May 2023 14:28:38 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 18 May 2023 14:28:38 -0400 From: Jeff King To: "brian m. carlson" Cc: git@vger.kernel.org, Junio C Hamano , Adam Majer Subject: Re: [PATCH v3 0/1] Fix empty SHA-256 clones with v0 and v1 Message-ID: <20230518182838.GB557383@coredump.intra.peff.net> References: <20230517192443.1149190-1-sandals@crustytoothpaste.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230517192443.1149190-1-sandals@crustytoothpaste.net> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, May 17, 2023 at 07:24:42PM +0000, brian m. carlson wrote: > Changes since v2: > * Move advertisement of fake capabilities ref to a separate function to > avoid an extra strcmp. Thanks, the code change looks good to me. I'm still a little puzzled why we need http tests both in t5551 and t5700. Not too big a deal to have redundant tests, obviously, but I wonder if I am missing something. -Peff