From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id B4FC71F406 for ; Fri, 12 May 2023 04:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239589AbjELEHj (ORCPT ); Fri, 12 May 2023 00:07:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjELEHh (ORCPT ); Fri, 12 May 2023 00:07:37 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0C90E55 for ; Thu, 11 May 2023 21:07:35 -0700 (PDT) Received: (qmail 2782 invoked by uid 109); 12 May 2023 04:07:35 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 12 May 2023 04:07:35 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 18027 invoked by uid 111); 12 May 2023 04:07:34 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 12 May 2023 00:07:34 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 12 May 2023 00:07:33 -0400 From: Jeff King To: Elijah Newren Cc: Calvin Wan , Elijah Newren via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH 23/24] hash-ll, hashmap: move oidhash() to hash-ll Message-ID: <20230512040733.GA1999607@coredump.intra.peff.net> References: <44a4027b240289605f4c40b9121ee6615e9759f7.1683431153.git.gitgitgadget@gmail.com> <20230511172401.934633-1-calvinwan@google.com> <20230511183143.GA1978320@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, May 11, 2023 at 07:08:00PM -0700, Elijah Newren wrote: > Oh, wow, I was about to type up an explanation to Calvin, but you did > so in even greater detail. Sweet. > > And sure, I'd be happy to split this out into a separate patch and > steal the commit message. I think you deserve Co-author, though, > given it's only a 1-line code change versus the 20 line commit message > you wrote... Great. I'm happy with any form of credit (or none). And the commit message is is S-o-b: me in case that matters. :) -Peff