From: Jeff King <peff@peff.net>
To: M Hickford <mirth.hickford@gmail.com>
Cc: "M Hickford via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
Cheetham <mjcheetham@outlook.com>,
Dennington <lessleydennington@gmail.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Calvin Wan" <calvinwan@google.com>
Subject: Re: [PATCH v2] credential: new attribute oauth_refresh_token
Date: Tue, 2 May 2023 06:25:12 -0400 [thread overview]
Message-ID: <20230502102512.GB1180695@coredump.intra.peff.net> (raw)
In-Reply-To: <CAGJzqsmAESKYd5AYoZ17pg0F9Oe2sK_Odwpk4niQK9njtpCkTg@mail.gmail.com>
On Tue, Apr 25, 2023 at 08:19:40PM +0100, M Hickford wrote:
> > > Add support for the new attribute to credential-cache. Eventually, I
> > > hope to see support in other popular storage helpers.
> >
> > At least your optimism is documented. :)
>
> I have a draft patch for credential-libsecret
> https://github.com/gitgitgadget/git/pull/1524 which I could add to
> this patch series if you like. Helpers credential-wincred and
> credential-osxkeychain would be easy to update following the same
> approach.
Good, thanks for doing that work. I don't think it needs to be part of
this series. Knowing that it's being worked on gives a sense that this
patch is going in a useful direction.
I do find the "shove extra data into the password field" strategy a
little gross, but that may be the best that can be done when interfacing
with existing stores. And at least the details are all contained inside
the helper itself (though I guess a user looking at it with other wallet
management tools would see the weird field).
-Peff
next prev parent reply other threads:[~2023-05-02 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 6:46 [PATCH] credential: new attribute oauth_refresh_token M Hickford via GitGitGadget
2023-04-21 9:47 ` [PATCH v2] " M Hickford via GitGitGadget
2023-04-21 16:50 ` Junio C Hamano
2023-04-24 20:11 ` M Hickford
2023-04-25 6:47 ` Jeff King
2023-04-25 19:19 ` M Hickford
2023-05-02 10:25 ` Jeff King [this message]
2023-05-02 16:19 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502102512.GB1180695@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=calvinwan@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=lessleydennington@gmail.com \
--cc=martin.agren@gmail.com \
--cc=mirth.hickford@gmail.com \
--cc=mjcheetham@outlook.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).