From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id ED1001F428 for ; Sat, 25 Mar 2023 08:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232366AbjCYIhw (ORCPT ); Sat, 25 Mar 2023 04:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232153AbjCYIhM (ORCPT ); Sat, 25 Mar 2023 04:37:12 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFCB418B0B for ; Sat, 25 Mar 2023 01:36:59 -0700 (PDT) Received: (qmail 12678 invoked by uid 109); 25 Mar 2023 08:36:59 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sat, 25 Mar 2023 08:36:59 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 11915 invoked by uid 111); 25 Mar 2023 08:36:58 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sat, 25 Mar 2023 04:36:58 -0400 Authentication-Results: peff.net; auth=none Date: Sat, 25 Mar 2023 04:36:58 -0400 From: Jeff King To: Eric Sunshine Cc: Michael J Gruber , git@vger.kernel.org, Phillip Wood , Derrick Stolee Subject: Re: [PATCH] t3070: make chain lint tester happy Message-ID: <20230325083658.GA3738217@coredump.intra.peff.net> References: <13accf6f99d367d137eefd02e3f6bf05bf099e00.1679328580.git.phillip.wood@dunelm.org.uk> <3714ba2f6528c38eb9c438126316a08b0cefca7c.1679696180.git.git@grubix.eu> <20230325063731.GB562387@coredump.intra.peff.net> <20230325075832.GA579632@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Mar 25, 2023 at 04:06:39AM -0400, Eric Sunshine wrote: > On Sat, Mar 25, 2023 at 3:58 AM Jeff King wrote: > > On Sat, Mar 25, 2023 at 02:54:45AM -0400, Eric Sunshine wrote: > > > I am unable to reproduce any linting errors when running this script > > > through chainlint, which is why I was more than a little confused by > > > this patch when I read it, and I was just about to ask for more > > > information, such as the actual error message. > > > > It's not your chain-lint script, but rather the builtin one that sticks > > "(exit 117) &&" in front of the snippet and evals it. So it creates the > > exact "foo && bar &" situation by prepending a line to the snippet. > > Thanks for clarifying that. I failed to infer that from the commit message. To be fair, I didn't figure it out from the commit either. It's just that running it stand-alone was the first thing I happened to try. ;) > Yes, I can reproduce it now. My mistake was that I tested 'seen' > rather than 1f2e05f0b79, not realizing that Junio had already applied > Michael's patch. (I meant to check if it had been applied, but forgot > to do so.) Oof. I got lucky twice, then, because I did run "seen" but I hadn't fetched recently enough. -Peff