Re: [PATCH v2 00/16] Header cleanups

[Jonathan Tan <jonathantanmy@google.com>]

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>  * Patch 1: leftover cleanup from en/header-cleanups (now in master) that
>    should have been included in that series
>  * Patches 2-4: cleanups around gettext.h. Without these patches, many
>    gettext inclusions would have to be squashed into later patches and make
>    them harder to review. Also, the implicit dependency on gettext.h was
>    making it much harder to find other dependencies.
>  * Patch 5: move some global var declarations from cache.h into the header
>    associated with where the vars are declared
>  * Patches 6-16: move header declarations from cache.h into a header named
>    the same as the source file containing the actual functions (e.g. move
>    declarations for abspath.c functions from cache.h into abspath.h), and
>    reduce the dependencies on cache.h accordingly.

Thanks for the effort. All the changes look good to me. (As for whether
gettext.h should go into cache.h/git-compat-util.h, I think that
individual files that use it should include it themselves, just as you
have done in this patch set. This means, among other things, that we can
reuse Git code in other projects that do not use gettext.)