From: John Cai <johncai86@gmail.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: John Cai via GitGitGadget <gitgitgadget@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] diff: support bare repositories when reading gitattributes for diff algorithm
Date: Tue, 14 Mar 2023 15:18:33 -0400 [thread overview]
Message-ID: <20230314191833.qmiisyvsu2ppu4sh@pop-os> (raw)
In-Reply-To: <ddd7cbb6-4f4d-ba0e-857e-5981779326d0@gmail.com>
On 23/03/14 01:21PM, Philippe Blain wrote:
> Hi John,
Hi Philippe,
>
> Le 2023-03-13 à 21:53, John Cai via GitGitGadget a écrit :
> > This patch series adds support for bare repositories for the feature added
> > in [1]. When using a bare repository, by default we will look for
> > gitattributes from HEAD. When the --attr-source option is passed, we will
> > try to read gitattributes from the commit.
>
> When I read that I immediately thought of the config settings 'mailmap.file',
> 'mailmap.blob' which allow the same sort of thing, but for the mailmap.
>
> For the sake of consistency of the whole system, maybe we would want to support
> 'attr.file' and 'attr.blob' ? In that case, maybe we don't need a new command
> line option at all...
I wasn't aware of those config options. Indeed that's a good option! My only
concern with that is that there is already some precedence for passing a
<tree-ish> as a source for attributes in [1], so I thought adding a command line
option would be somewhat consistent.
But I can also see the benefit of using a config value since there is also
precedence because of mailmap.file and mailmap.blob. Not sure what others think,
but this may be the less invasive way to go.
1. https://git-scm.com/docs/git-check-attr#Documentation/git-check-attr.txt---sourcelttree-ishgt
>
> Cheers,
>
> Philippe.
next prev parent reply other threads:[~2023-03-14 19:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 1:53 [PATCH 0/2] diff: support bare repositories when reading gitattributes for diff algorithm John Cai via GitGitGadget
2023-03-14 1:53 ` [PATCH 1/2] diff: use HEAD for attributes when using bare repository John Cai via GitGitGadget
2023-03-14 16:54 ` Junio C Hamano
2023-03-14 17:43 ` Junio C Hamano
2023-03-14 19:38 ` John Cai
2023-03-14 20:37 ` Junio C Hamano
2023-03-16 16:46 ` John Cai
2023-03-16 22:56 ` Junio C Hamano
2023-03-17 14:11 ` John Cai
2023-03-14 1:53 ` [PATCH 2/2] diff: add --attr-source to read gitattributes from a commit John Cai via GitGitGadget
2023-03-14 17:21 ` [PATCH 0/2] diff: support bare repositories when reading gitattributes for diff algorithm Philippe Blain
2023-03-14 19:18 ` John Cai [this message]
2023-03-14 20:44 ` Junio C Hamano
2023-03-16 14:29 ` Jeff King
2023-03-16 16:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314191833.qmiisyvsu2ppu4sh@pop-os \
--to=johncai86@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).