From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-11.2 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 21F171F5A0 for ; Wed, 1 Feb 2023 23:55:58 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=kYRQJBYm; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbjBAXzu (ORCPT ); Wed, 1 Feb 2023 18:55:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjBAXzs (ORCPT ); Wed, 1 Feb 2023 18:55:48 -0500 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87A7137F25 for ; Wed, 1 Feb 2023 15:55:47 -0800 (PST) Received: by mail-pf1-x44a.google.com with SMTP id a27-20020aa78e9b000000b00593f636220cso21934pfr.11 for ; Wed, 01 Feb 2023 15:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=gc69kjGTsaqOTfDszctxURgPgIXTqomOpIlkgwhZDrA=; b=kYRQJBYm+InsdftSZLWJepu/C+oUvcLKE7idyqovUBy/UR2FCWa5eQxILKq7OYwD1b BRjDs7NzIVEvGKX5TqisUNOuJ+Q0ZWuy1be+0KP36VjFn8qv11t54/2Tn/hZk8RY3rtK MCYQIm14RjfJZLAcf4Lz1H4YozWZgHRTySjd013ZaXuHFUV7xIG1PuBA2i0sabjx584Q ubcbzd3PAZKzHCWlV88IMQMicC7rqXgJ62KPEhpIngoPiT9IeoE6C8K0yVJ2cVfjG0rk NzJ5TO+YtLfigXeckWqVdpTyN7gxgJhP3aVmGVzQnY2ZrfTmN8y/totlAQbZRzeE/6Ax VVcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gc69kjGTsaqOTfDszctxURgPgIXTqomOpIlkgwhZDrA=; b=tFVlT4xwjchCDLNqHHaKD+SNPIu4HOLBBFii/I9f3y+KPnkHkZNBdsf072QiAG0QB4 ujZq5mYYAgMdfAc5AjLkG2ufSO8gGae4jtprfm5gAKO4YLsWpn74mkJuVv00oiiSJ118 UOmkJdSoVW/lrp8Vq+1XFFJzV0nWLvhxY/fIhPC9agtL6yMuLGqZqXvYOtnVyyv5AINH a4tHyqrKGvVvIb2bYJSwTNd/XNzaJPeu/8aGM+SpPbRA4RwVdqEUUaAiV3a7WcJyzdil 0l7/Alrj2e1lNYthB61KbM2Q9oITPS4V+WgbOtXb/LIyFwQtP53M85uXdQlAaON4GwVL p4fg== X-Gm-Message-State: AO0yUKVfyaF6wmOEII0h5FQvjwl+zkKHjH5W3+KSObDnO+pe5uR7E2WC Ujwy8SK9Khq6MsJoHhbTYoFt++DAcMCS4U8= X-Google-Smtp-Source: AK7set/aQGTFshK7Uxva76K6VAA0ZzCJmfCypduJoEMr/XLX1frJYHgT5iL33UPODlwUdi90C5/GUsDYSU409J4= X-Received: from barleywine.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3bd4]) (user=calvinwan job=sendgmr) by 2002:a17:902:ecce:b0:196:6c8c:288f with SMTP id a14-20020a170902ecce00b001966c8c288fmr1091534plh.32.1675295747046; Wed, 01 Feb 2023 15:55:47 -0800 (PST) Date: Wed, 1 Feb 2023 23:52:52 +0000 In-Reply-To: <20230119223858.29262-5-zev@bewilderbeest.net> Mime-Version: 1.0 References: <20230201235253.1891546-1-calvinwan@google.com> X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog Message-ID: <20230201235253.1891546-4-calvinwan@google.com> Subject: Re: [PATCH 4/5] pretty: Add name_and_address_only parameter From: Calvin Wan To: Zev Weiss Cc: Calvin Wan , git@vger.kernel.org, Emma Brooks , Hamza Mahfooz , Junio C Hamano Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Zev Weiss writes: > This is meant to be used with pp_user_info() when using it to format > email recipients generated by --to-cmd/--cc-cmd. When set it omits > the leading 'From: ', trailing linefeed, and the date suffix, and > additionally will return the input string unmodified if > split_ident_line() can't parse it (e.g. for a bare email address). I think the ideal solution, instead of choosing this hacky approach, is to refactor out the common functionality you need from pp_user_info() and to call that instead in your next patch.