mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Calvin Wan <>
To: Zev Weiss <>
Cc: "Calvin Wan" <>,, "Junio C Hamano" <>,
	"Eric Sunshine" <>,
	"brian m. carlson" <>,
	"Ævar Arnfjörð Bjarmason" <>,
	"Patrick Hemmer" <>,
	"René Scharfe" <>,
	"Denton Liu" <>,
	"Emma Brooks" <>,
	"Hamza Mahfooz" <>
Subject: Re: [PATCH 0/5] format-patch: Add --{to,cc}-cmd support
Date: Wed,  1 Feb 2023 23:52:49 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Zev! Thanks for the patch series. I agree that these flags are a very
good idea to add. I appreciate the well written cover letter -- it does
well describing the need for this series and calling out design
questions. I'll leave the rest of my comments in the particular patches,
looking forward to the reroll!

>  - As currently written any commands specified are only run on the
>    patches themselves, not on the cover letter.  The slight
>    inconsistency with git-send-email is a bit unfortunate, but I
>    figure it's probably not often all that useful in that context
>    anyway (and the implementation looked like it would be just
>    non-trivial enough that laziness may have played a role as well).

It is also inconsistent with git-format-patch --to and --cc. I strongly
believe that your flags should also work with the cover letter, since
users should expect equivalency across similar flags. git-send-email has
config options, sendemail.tocmd and sendemail.cccmd, that I also believe
should be implemented.

      parent reply	other threads:[~2023-02-01 23:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 22:38 [PATCH 0/5] format-patch: Add --{to,cc}-cmd support Zev Weiss
2023-01-19 22:38 ` [PATCH 1/5] t4014: Add test checking cover-letter To header Zev Weiss
2023-02-01 23:52   ` Calvin Wan
2023-01-19 22:38 ` [PATCH 2/5] log: Refactor duplicated code to headerize recipient lists Zev Weiss
2023-01-25  2:11   ` Junio C Hamano
2023-01-19 22:38 ` [PATCH 3/5] log: Push to/cc handling down into show_log() Zev Weiss
2023-01-20  0:33   ` Junio C Hamano
2023-02-01 23:52   ` Calvin Wan
2023-01-19 22:38 ` [PATCH 4/5] pretty: Add name_and_address_only parameter Zev Weiss
2023-01-25  2:23   ` Junio C Hamano
2023-02-01 23:52   ` Calvin Wan
2023-01-19 22:38 ` [PATCH 5/5] format-patch: Add support for --{to,cc}-cmd flags Zev Weiss
2023-02-01 23:52   ` Calvin Wan
2023-02-01 23:52 ` Calvin Wan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).