git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Askar Safin <safinaskar@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, git@vger.kernel.org
Subject: Re: https://github.com/rust-lang/rust is not bisectable
Date: Sun, 18 Dec 2022 11:52:39 +0100	[thread overview]
Message-ID: <20221218105239.GD3411@szeder.dev> (raw)
In-Reply-To: <CAPnZJGBwFMPAJKj9Qa_Vv9yJWrGaNXqaNaPUSrYcjZ8J+OfLrg@mail.gmail.com>

On Sun, Dec 18, 2022 at 01:03:54PM +0300, Askar Safin wrote:
> SZEDER Gábor, yes, in this particular case this helps.

Not just in this particular case, but this solves a general issue of
bisecting non-linear histories that is the file/testcase/whatever of
interest is not present in all candidate revisions in the range '^good
bad'.

> (But
> I still wonder how to tell git-bisect to ignore commits, which are not
> descendants of good commit.)

In general you do not want to tell that to bisect, because any one of
them could have introduced the change you are looking for.  Consider
the following piece of history, where commits 'm<N>' are on the master
branch, 'b<N>' are on a different branch, and the commit marked with C
made a buggy change, and commits marked with G and B are the ones you
marked as good and bad you started the bisection.

            (G)            (M)  (B)
  m1---m2---m3---m4---m5---m6---m7
        \                 /
         b1---b2---b3---b4
                   (C)

If bisect were to ignore commits "which are not descendants of good
commit", then it wouldn't look at any of the 'b<N>' commits made on
the side branch.  It would only look at commits m{3,4,5,6,7}, and thus
report m6 as the first bad commit, which is clearly not the case.



  parent reply	other threads:[~2022-12-18 10:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17 16:00 https://github.com/rust-lang/rust is not bisectable Askar Safin
2022-12-17 16:34 ` Andreas Schwab
2022-12-18  3:15   ` Askar Safin
2022-12-18  9:16     ` Andreas Schwab
2022-12-18  9:37     ` SZEDER Gábor
2022-12-18 10:03       ` Askar Safin
2022-12-18 10:25         ` Andreas Schwab
2022-12-18 10:52         ` SZEDER Gábor [this message]
2022-12-18 14:10           ` rsbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221218105239.GD3411@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=safinaskar@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).