From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 134F71F910 for ; Sat, 5 Nov 2022 18:46:06 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=rjp.ie header.i=@rjp.ie header.b="RGTbRQME"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbiKESqC (ORCPT ); Sat, 5 Nov 2022 14:46:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbiKESp6 (ORCPT ); Sat, 5 Nov 2022 14:45:58 -0400 Received: from out0.migadu.com (out0.migadu.com [IPv6:2001:41d0:2:267::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E71114D37 for ; Sat, 5 Nov 2022 11:45:55 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjp.ie; s=key1; t=1667673953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vlOHok/g4+2qOVolG4b7FI4MFNnmpe5EryUoGbgEe7E=; b=RGTbRQMEbIereMtxR1uKY25hZkzmwuUbQDBBu7gt/0w2R2d+vYh7061GnBj9PLuIor26Wc A+fjqKpuYkq45GQg8gC/AuKhftzzFsF8fOwCQsazIjiviUFjn/IOuJdErKcbCsPuZDStlm IY+cza42IGQbcxhEYCKe7ajkDDCAzQ8= From: Ronan Pigott To: git@vger.kernel.org Cc: Jeff King , Eric Sunshine , Clement Moyroud , Derrick Stolee , Alex Henrie , Junio C Hamano , =?UTF-8?q?SZEDER=20G=C3=A1bor?= , =?UTF-8?q?Martin=20=C3=85gren?= , Thomas Ackermann Subject: [PATCH 2/2] maintenance: add option to register in a specific config Date: Sat, 5 Nov 2022 11:45:32 -0700 Message-Id: <20221105184532.457043-3-ronan@rjp.ie> In-Reply-To: <20221105184532.457043-1-ronan@rjp.ie> References: <20221105184532.457043-1-ronan@rjp.ie> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org maintenance register currently records the maintenance repo exclusively within the user's global configuration, but other configuration files may be relevant when running maintenance if they are included from the global config. This option allows the user to choose where maintenance repos are recorded. Signed-off-by: Ronan Pigott --- I track my global config in a bare gitrepo, and include host-specific configuration from an auxiliary path. Since on each host I may work on different repos, at different paths, and have different preferences for prefetch or gc frequency, I record maintenance repos in this host-specific config. This option will facilitate this use case. Documentation/git-maintenance.txt | 14 +++++++------- builtin/gc.c | 28 +++++++++++++++++----------- t/t7900-maintenance.sh | 15 +++++++++++++++ 3 files changed, 39 insertions(+), 18 deletions(-) diff --git a/Documentation/git-maintenance.txt b/Documentation/git-maintenance.txt index bb888690e4..eb3ae9fbd5 100644 --- a/Documentation/git-maintenance.txt +++ b/Documentation/git-maintenance.txt @@ -50,13 +50,13 @@ stop:: the background maintenance is restarted later. register:: - Initialize Git config values so any scheduled maintenance will - start running on this repository. This adds the repository to the - `maintenance.repo` config variable in the current user's global - config and enables some recommended configuration values for - `maintenance..schedule`. The tasks that are enabled are safe - for running in the background without disrupting foreground - processes. + Initialize Git config values so any scheduled maintenance will start + running on this repository. This adds the repository to the + `maintenance.repo` config variable in the current user's global config, + or the config specified by --config option, and enables some + recommended configuration values for `maintenance..schedule`. The + tasks that are enabled are safe for running in the background without + disrupting foreground processes. + The `register` subcommand will also set the `maintenance.strategy` config value to `incremental`, if this value is not previously set. The diff --git a/builtin/gc.c b/builtin/gc.c index 24ea85c7af..5da6905033 100644 --- a/builtin/gc.c +++ b/builtin/gc.c @@ -1454,13 +1454,15 @@ static char *get_maintpath(void) } static char const * const builtin_maintenance_register_usage[] = { - "git maintenance register", + "git maintenance register [--config ]", NULL }; static int maintenance_register(int argc, const char **argv, const char *prefix) { + const char *config_file = NULL; struct option options[] = { + OPT_STRING('c', "config", &config_file, N_("file"), N_("use given config file")), OPT_END(), }; int found = 0; @@ -1502,7 +1504,7 @@ static int maintenance_register(int argc, const char **argv, const char *prefix) if (!user_config) die(_("$HOME not set")); rc = git_config_set_multivar_in_file_gently( - user_config, "maintenance.repo", maintpath, + config_file ?: user_config, "maintenance.repo", maintpath, CONFIG_REGEX_NONE, 0); free(user_config); free(xdg_config); @@ -1517,14 +1519,16 @@ static int maintenance_register(int argc, const char **argv, const char *prefix) } static char const * const builtin_maintenance_unregister_usage[] = { - "git maintenance unregister [--force]", + "git maintenance unregister [--config ] [--force]", NULL }; static int maintenance_unregister(int argc, const char **argv, const char *prefix) { int force = 0; + const char *config_file = NULL; struct option options[] = { + OPT_STRING('c', "config", &config_file, N_("file"), N_("use given config file")), OPT__FORCE(&force, N_("return success even if repository was not registered"), PARSE_OPT_NOCOMPLETE), @@ -1542,24 +1546,26 @@ static int maintenance_unregister(int argc, const char **argv, const char *prefi usage_with_options(builtin_maintenance_unregister_usage, options); - list = git_config_get_value_multi(key); - if (list) { - for_each_string_list_item(item, list) { - if (!strcmp(maintpath, item->string)) { - found = 1; - break; + if (!config_file) { + list = git_config_get_value_multi(key); + if (list) { + for_each_string_list_item(item, list) { + if (!strcmp(maintpath, item->string)) { + found = 1; + break; + } } } } - if (found) { + if (found || config_file) { int rc; char *user_config, *xdg_config; git_global_config(&user_config, &xdg_config); if (!user_config) die(_("$HOME not set")); rc = git_config_set_multivar_in_file_gently( - user_config, key, NULL, maintpath, + config_file ?: user_config, key, NULL, maintpath, CONFIG_FLAGS_MULTI_REPLACE | CONFIG_FLAGS_FIXED_VALUE); free(user_config); free(xdg_config); diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh index 96bdd42045..c2c2dbbb5f 100755 --- a/t/t7900-maintenance.sh +++ b/t/t7900-maintenance.sh @@ -500,6 +500,21 @@ test_expect_success 'register and unregister' ' git config --global --get-all maintenance.repo >actual && test_cmp before actual && + git config --file ./other --add maintenance.repo /existing1 && + git config --file ./other --add maintenance.repo /existing2 && + git config --file ./other --get-all maintenance.repo >before && + + git maintenance register --config ./other && + test_cmp_config false maintenance.auto && + git config --file ./other --get-all maintenance.repo >between && + cp before expect && + pwd >>expect && + test_cmp expect between && + + git maintenance unregister --config ./other && + git config --file ./other --get-all maintenance.repo >actual && + test_cmp before actual && + test_must_fail git maintenance unregister 2>err && grep "is not registered" err && git maintenance unregister --force -- 2.38.1