From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Elijah Newren <newren@gmail.com>
Cc: Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Derrick Stolee <derrickstolee@github.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Josh Steadmon <steadmon@google.com>,
Glen Choo <chooglen@google.com>,
Junio C Hamano <gitster@pobox.com>,
Victoria Dye <vdye@github.com>
Subject: Re: [PATCH v2] Documentation: add ReviewingGuidelines
Date: Tue, 20 Sep 2022 17:23:50 -0400 [thread overview]
Message-ID: <20220920212350.f5do44qqduhyp46u@meerkat.local> (raw)
In-Reply-To: <CABPp-BEB_+YoKZ=U6NPc8J+KZyMSYRsom34CeqjxUCyw0=LEyg@mail.gmail.com>
On Mon, Sep 19, 2022 at 05:43:15PM -0700, Elijah Newren wrote:
> > +- You may find that the limited context provided in the patch diff is sometimes
> > + insufficient for a thorough review. In such cases, you can review patches in
> > + your local tree by either applying patches with linkgit:git-am[1] or checking
> > + out the associated branch from https://github.com/gitster/git once the series
> > + is tracked there.
>
> Lots of reviews also come with "Fetch-It-Via" instructions in the
> cover letter, making it really easy to grab. Might be worth
> mentioning?
>
> Also, would it make sense for us to replace "applying" with
> "downloading and applying", perhaps mentioning `b4 am` for the
> downloading half?
B4 can also "convert" a patch series into a pull request using "shazam".
E.g.:
b4 shazam -H <msgid>
This will do some behind-the-scenes magic and give you a FETCH_HEAD that you
can review, check out into a new branch, merge, etc.
You can try this with this very thread, if you are inside the git's own repo:
$ b4 shazam -H pull.1348.git.1662747205235.gitgitgadget@gmail.com
Grabbing thread from lore.kernel.org/all/pull.1348.git.1662747205235.gitgitgadget%40gmail.com/t.mbox.gz
Checking for newer revisions on https://lore.kernel.org/all/
Analyzing 12 messages in the thread
Will use the latest revision: v2
You can pick other revisions using the -vN flag
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v2] Documentation: add ReviewingGuidelines
+ Reviewed-by: Josh Steadmon <steadmon@google.com> (✓ DKIM/google.com)
---
✓ Signed: DKIM/gmail.com
---
Total patches: 1
---
Magic: Preparing a sparse worktree
---
Applying: Documentation: add ReviewingGuidelines
---
Fetching into FETCH_HEAD
You can now merge or checkout FETCH_HEAD
e.g.: git merge --no-ff -F /home/user/work/git/git/.git/b4-cover --edit FETCH_HEAD --signoff
> (I tend to use the Fetch-It-Via or wait for it to show up in
> gitster/git, but b4 is really nice for the other cases.)
Great to hear! :)
-Konstantin
next prev parent reply other threads:[~2022-09-20 21:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 18:13 [PATCH] Documentation: add ReviewingGuidelines Victoria Dye via GitGitGadget
2022-09-09 19:42 ` Junio C Hamano
2022-09-13 17:54 ` Junio C Hamano
2022-09-13 23:11 ` Victoria Dye
2022-09-19 15:08 ` Derrick Stolee
2022-09-19 15:48 ` Johannes Schindelin
2022-09-15 23:25 ` Josh Steadmon
2022-09-19 18:17 ` Glen Choo
2022-09-19 19:12 ` [PATCH v2] " Victoria Dye via GitGitGadget
2022-09-19 20:15 ` Josh Steadmon
2022-09-19 21:37 ` Junio C Hamano
2022-09-20 0:43 ` Elijah Newren
2022-09-20 21:23 ` Konstantin Ryabitsev [this message]
2022-09-22 4:24 ` Shaoxuan Yuan
2022-09-22 13:29 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920212350.f5do44qqduhyp46u@meerkat.local \
--to=konstantin@linuxfoundation.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=chooglen@google.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=steadmon@google.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).