From: Fernando Ramos <greenfoo@u92.eu>
To: greenfoo@u92.eu
Cc: felipe.contreras@gmail.com, git@vger.kernel.org
Subject: [PATCH v3 0/3] mergetools: vimdiff: regression fix (vimdiff3 mode)
Date: Mon, 8 Aug 2022 07:34:56 +0200 [thread overview]
Message-ID: <20220808053459.184367-1-greenfoo@u92.eu> (raw)
In-Reply-To: <20220807024941.222018-1-felipe.contreras@gmail.com>
Felipe detected that color highlighting no longer worked when running "git
mergetools -t vimdiff3".
Deeper inspection of the problem revealed that color highlighting was also not
working in other cases (layouts that contained a single window in one of their
tabs)
The current patch series fixes the issue by doing two things:
1. Making single tab + single window modes (such as "vimdiff3") use the same
code path as all other layouts.
2. Fixing the general "single window" case so that color highlighting also
works there (and this is achieved by adding all buffers to the diff group
in single window tabs).
In other words, after this patch:
A) Tabs with more than one window will only highlight differences between the
buffers shown in those windows.
B) Tabs with just one window (and this also covers the more specific case of
layouts with just one tab containing one window) will highlight differences
between all buffers (LOCAL, BASE, REMOTE, MERGED).
Felipe Contreras (1):
mergetools: vimdiff: fix comment
Fernando Ramos (2):
mergetools: vimdiff: fix single tab mode, single window mode and
colors
mergetools: vimdiff: update unit tests
mergetools/vimdiff | 109 +++++++++++++++++++++++++++++----------------
1 file changed, 70 insertions(+), 39 deletions(-)
--
2.37.1
next prev parent reply other threads:[~2022-08-08 5:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 2:49 [PATCH v2 0/9] mergetools: vimdiff: regression fix and reorg Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 1/9] mergetools: vimdiff: fix comment Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 2/9] mergetools: vimdiff: shuffle single window case Felipe Contreras
2022-08-07 14:46 ` Fernando Ramos
2022-08-07 15:44 ` Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 3/9] mergetools: vimdiff: add get_buf() helper Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 4/9] mergetools: vimdiff: make vimdiff3 actually work Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 5/9] mergetools: vimdiff: silence annoying messages Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 6/9] mergetools: vimdiff: fix for diffopt Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 7/9] mergetools: vimdiff: cleanup cruft Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 8/9] mergetools: vimdiff: fix single window mode Felipe Contreras
2022-08-07 2:49 ` [PATCH v2 9/9] mergetools: vimdiff: use vimdiff for vimdiff3 Felipe Contreras
2022-08-07 14:46 ` Fernando Ramos
2022-08-07 7:54 ` [PATCH v2 0/9] mergetools: vimdiff: regression fix and reorg Fernando Ramos
2022-08-07 15:39 ` Felipe Contreras
2022-08-07 18:39 ` Fernando Ramos
2022-08-07 18:43 ` [PATCH 1/2] vimdiff: fix single tab mode, single window mode and colors Fernando Ramos
2022-08-07 18:43 ` [PATCH 2/2] vimdiff: update unit tests Fernando Ramos
2022-08-07 22:27 ` [PATCH v2 0/9] mergetools: vimdiff: regression fix and reorg Felipe Contreras
2022-08-08 5:34 ` Fernando Ramos [this message]
2022-08-08 5:34 ` [PATCH v3 1/3] mergetools: vimdiff: fix comment Fernando Ramos
2022-08-08 5:34 ` [PATCH v3 2/3] mergetools: vimdiff: fix single tab mode, single window mode and colors Fernando Ramos
2022-08-08 6:37 ` Felipe Contreras
2022-08-08 18:14 ` Fernando Ramos
2022-08-08 21:00 ` Felipe Contreras
2022-08-08 21:51 ` Fernando Ramos
2022-08-09 0:59 ` Felipe Contreras
2022-08-08 5:34 ` [PATCH v3 3/3] mergetools: vimdiff: update unit tests Fernando Ramos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808053459.184367-1-greenfoo@u92.eu \
--to=greenfoo@u92.eu \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).