git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Tan <jonathantanmy@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Tan <jonathantanmy@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] fetch-pack: make unexpected peek result non-fatal
Date: Mon, 16 May 2022 23:20:34 -0700	[thread overview]
Message-ID: <20220517062035.3648639-1-jonathantanmy@google.com> (raw)
In-Reply-To: <xmqqr14t4fwf.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:
> We used to die unless READ_NORMAL was returned, so the code after
> packet_reader_peek() can rely on reader->line to be populated.  Now
> that code must handle cases where an earlier _peek() gave something
> other than READ_NORMAL and in such an error case reader->line points
> at NULL.  So any code that assumed reader->line was populated needs
> to be updated.
> 
> Makes sense.

Thanks for taking a look. Yes, that's correct.

      reply	other threads:[~2022-05-17  6:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 11:02 [PATCH] fetch-pack: make unexpected peek result non-fatal Jonathan Tan
2022-05-16 16:10 ` Junio C Hamano
2022-05-17  6:20   ` Jonathan Tan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517062035.3648639-1-jonathantanmy@google.com \
    --to=jonathantanmy@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).