From: Jonathan Tan <firstname.lastname@example.org> To: Taylor Blau <email@example.com> Cc: Jonathan Tan <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH 2/2] builtin/pack-objects.c: ensure pack validity from MIDX bitmap objects Date: Sun, 15 May 2022 23:07:44 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <Yn+r4lPi8vNK/qFG@nand.local> Taylor Blau <email@example.com> writes: > Perhaps changing the parenthetical to be: > > (indicating that `want_object_in_pack()` should continue searching > for other packs containing this object) This works, thanks. > Yes, `want_found_object()` could have returned -1 before, but the only > time when `*found_pack != NULL` and `want_found_object()` would have returned > -1 is when given `--local` with at least one non-local pack. > > I actually think it's possible we have a bug there, since AFAICT the > pre-image of this patch would have left the non-NULL `*found_pack` alone > but picked a copy of the given object from a _different_ pack. So I > think this change inadvertently resolves that bug. [snip] > I think my reply above indicates why this change is necessary, but if > we're talking about separate issues, let me know. Ah, I was presupposing that the existing code works correctly. But yes, this makes sense.
next prev parent reply other threads:[~2022-05-16 6:09 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-13 16:23 [PATCH 0/2] pack-objects: fix a pair of MIDX bitmap-related races Taylor Blau 2022-05-13 16:23 ` [PATCH 1/2] pack-bitmap: check preferred pack validity when opening MIDX bitmap Taylor Blau 2022-05-13 18:19 ` Junio C Hamano 2022-05-13 19:55 ` Taylor Blau 2022-05-13 16:23 ` [PATCH 2/2] builtin/pack-objects.c: ensure pack validity from MIDX bitmap objects Taylor Blau 2022-05-13 23:06 ` Jonathan Tan 2022-05-14 13:17 ` Taylor Blau 2022-05-16 6:07 ` Jonathan Tan [this message] 2022-05-14 13:34 ` Taylor Blau 2022-05-16 6:11 ` Jonathan Tan 2022-05-24 18:54 ` [PATCH v2 0/4] pack-objects: fix a pair of MIDX bitmap-related races Taylor Blau 2022-05-24 18:54 ` [PATCH v2 1/4] pack-bitmap.c: check preferred pack validity when opening MIDX bitmap Taylor Blau 2022-05-24 19:36 ` Ævar Arnfjörð Bjarmason 2022-05-24 21:38 ` Taylor Blau 2022-05-24 21:51 ` Ævar Arnfjörð Bjarmason 2022-05-24 18:54 ` [PATCH v2 2/4] builtin/pack-objects.c: avoid redundant NULL check Taylor Blau 2022-05-24 21:44 ` Junio C Hamano 2022-05-25 0:11 ` Taylor Blau 2022-05-24 18:54 ` [PATCH v2 3/4] builtin/pack-objects.c: ensure included `--stdin-packs` exist Taylor Blau 2022-05-24 19:46 ` Ævar Arnfjörð Bjarmason 2022-05-24 21:33 ` Taylor Blau 2022-05-24 21:49 ` Ævar Arnfjörð Bjarmason 2022-05-24 22:03 ` Junio C Hamano 2022-05-25 0:14 ` Taylor Blau 2022-05-26 19:21 ` Victoria Dye 2022-05-26 20:05 ` Taylor Blau 2022-05-24 18:54 ` [PATCH v2 4/4] builtin/pack-objects.c: ensure pack validity from MIDX bitmap objects Taylor Blau 2022-05-24 21:38 ` [PATCH v2 0/4] pack-objects: fix a pair of MIDX bitmap-related races Junio C Hamano 2022-05-25 0:16 ` Taylor Blau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 2/2] builtin/pack-objects.c: ensure pack validity from MIDX bitmap objects' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).