From: Goss Geppert <gg.oss.dev@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
christian w <usebees@gmail.com>, Elijah Newren <newren@gmail.com>,
Derrick Stolee <derrickstolee@github.com>
Subject: [RFC PATCH 0/1] dir: consider worktree config in path recursion
Date: Thu, 5 May 2022 20:32:33 +0000 [thread overview]
Message-ID: <20220505203234.21586-1-ggossdev@gmail.com> (raw)
Please see the commit message for a description. Effectively, since
8d92fb2927 (dir: replace exponential algorithm with a linear one,
2020-04-01) the following no longer does what it used to do:
```
test_repo="$(mktemp -d /tmp/git-test-XXXXXXX)"
cd "$test_repo"
>test-file
git init
git config core.worktree /tmp
git add test-file
```
In terms of desired behavior, it seems that if it is possible to track
files that are outside the default worktree, then it should also be
possible to track files inside the default worktree location.
Personally, I was using this setup to track dotfiles and some other
system related snippets and liked that design more than alternatives I'm
aware of. I ran into this problem because I was recently unable to add a
file to an existing repository with this configuration.
There are a couple open items but I wanted to get some feedback to
confirm that the behavior of this patch is desirable or if I'm
overlooking something entirely.
TODOs:
[ ] add test
[ ] add signoffs
Goss Geppert (1):
dir: consider worktree config in path recursion
dir.c | 37 ++++++++++++++++++++++++++++++-------
1 file changed, 30 insertions(+), 7 deletions(-)
base-commit: 0f828332d5ac36fc63b7d8202652efa152809856
--
2.36.0
next reply other threads:[~2022-05-05 20:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 20:32 Goss Geppert [this message]
2022-05-05 20:32 ` [RFC PATCH 1/1] dir: consider worktree config in path recursion Goss Geppert
2022-05-07 3:26 ` Elijah Newren
2022-05-07 17:59 ` oss dev
2022-05-06 17:02 ` [RFC PATCH 0/1] " Junio C Hamano
2022-05-06 20:00 ` oss dev
2022-05-10 17:15 ` [PATCH v2 0/2] " Goss Geppert
2022-05-10 17:15 ` [PATCH v2 1/2] " Goss Geppert
2022-05-11 16:37 ` Junio C Hamano
2022-05-20 19:45 ` oss dev
2022-05-24 14:29 ` Elijah Newren
2022-05-24 19:45 ` Junio C Hamano
2022-05-25 3:46 ` Elijah Newren
2022-05-11 23:07 ` Junio C Hamano
2022-05-20 20:01 ` oss dev
2022-05-23 19:23 ` Derrick Stolee
2022-05-30 18:48 ` oss dev
2022-05-10 17:15 ` [PATCH v2 2/2] dir: minor refactoring / clean-up Goss Geppert
2022-05-11 16:51 ` Junio C Hamano
2022-05-20 20:03 ` oss dev
2022-05-20 19:28 ` [PATCH v3 0/3] dir: traverse into repository Goss Geppert
2022-05-20 19:28 ` [PATCH v3 1/3] " Goss Geppert
2022-05-20 19:28 ` [PATCH v3 2/3] dir: cache git_dir's realpath Goss Geppert
2022-05-24 14:32 ` Elijah Newren
2022-05-20 19:28 ` [PATCH v3 3/3] dir: minor refactoring / clean-up Goss Geppert
2022-06-16 23:19 ` [PATCH v4 0/2] dir: traverse into repository Goss Geppert
2022-06-22 4:57 ` Elijah Newren
[not found] ` <20220616231956.154-1-gg.oss@outlook.com>
2022-06-16 23:19 ` [PATCH v4 1/2] " Goss Geppert
2022-06-16 23:44 ` [PATCH v4 0/2] dir: traverse into repository (resending) Goss Geppert
[not found] ` <20220616234433.225-1-gg.oss@outlook.com>
2022-06-16 23:44 ` [PATCH v4 1/2] dir: traverse into repository Goss Geppert
2022-06-16 23:44 ` [PATCH v4 2/2] dir: minor refactoring / clean-up Goss Geppert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505203234.21586-1-ggossdev@gmail.com \
--to=gg.oss.dev@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=usebees@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).