From: Alyssa Ross <hi@alyssa.is>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Failures in t9001-send-email
Date: Thu, 21 Apr 2022 22:38:43 +0000 [thread overview]
Message-ID: <20220421223843.6z3y4bnrbu76erhk@eve> (raw)
In-Reply-To: <220421.86tuam5hoi.gmgdl@evledraar.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]
> I think a patch to do that would be worth having/reviewing (hint
> hint!). As always the real work is updating docs, running the tests
> etc., digging up ML discussions to see if there's been any past
> arguments for/against it etc.
>
> In this case the code change itself should be trivial (I honestly didn't
> look this time, but really, it's a config default...). So this seems
> like a perfect task for someone not too familiar with Git's codebase,
> but still interested in contributing :)
I thought I'd have a go at a patch, but I wasn't able to get the tests
running:
prove ./t9001-send-email.sh
./t9001-send-email.sh .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 15/188 subtests
(less 1 skipped subtest: 172 okay)
Test Summary Report
-------------------
./t9001-send-email.sh (Wstat: 256 Tests: 188 Failed: 15)
Failed tests: 27, 51, 78-84, 123, 147-150, 185
Non-zero exit status: 1
Files=1, Tests=188, 17 wallclock secs ( 0.06 usr 0.01 sys + 11.66 cusr 5.37 csys = 17.10 CPU)
Result: FAIL
I had a look at the tests to try to guess what was wrong, but I didn't
come up with anything. Any ideas? When I run make test, every other
test is fine, it's just the send-email tests that are problematic.
(My git source tree is v2.36.0.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-21 22:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 19:48 Should sendemail.confirm default to always? Alyssa Ross
2022-04-21 19:58 ` Ævar Arnfjörð Bjarmason
2022-04-21 21:47 ` Junio C Hamano
2022-04-21 22:38 ` Alyssa Ross [this message]
2022-04-21 23:19 ` Failures in t9001-send-email rsbecker
2022-04-22 7:56 ` Alyssa Ross
2022-04-22 10:41 ` rsbecker
2022-04-22 5:40 ` Johannes Sixt
2022-04-22 6:51 ` Junio C Hamano
2022-04-22 8:00 ` Alyssa Ross
2022-04-22 8:36 ` [PATCH] send-email: always confirm by default Alyssa Ross
2022-04-22 11:16 ` Ævar Arnfjörð Bjarmason
2022-04-22 17:09 ` Junio C Hamano
2022-04-21 20:04 ` Should sendemail.confirm default to always? Junio C Hamano
2022-04-21 20:37 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421223843.6z3y4bnrbu76erhk@eve \
--to=hi@alyssa.is \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).