From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6E2DE1F4CE for ; Mon, 11 Apr 2022 18:18:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346227AbiDKSUj (ORCPT ); Mon, 11 Apr 2022 14:20:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbiDKSUh (ORCPT ); Mon, 11 Apr 2022 14:20:37 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B7E91DA53 for ; Mon, 11 Apr 2022 11:18:22 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 345B41F38D; Mon, 11 Apr 2022 18:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649701101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I49lhvIOeqxV282QBWnpGg6hKJSrJuF1g1A9TGsArZo=; b=woM8YWIi2tgd9KzLYbcWaIBbWBaEt2NovYpdy6Eap2Q+42e75nhrZnMON4LpWmQFYrmjqM y6sq5gt17UKoslOJCQ7UeYvraMVrJHb5sTAjYkQ6rFoqZBmcm0xwWW8gnF8gQa78MpKd8T 5ZuxjOdqRiiQ3hMk8uHKfWhzWHZ6pDA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649701101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I49lhvIOeqxV282QBWnpGg6hKJSrJuF1g1A9TGsArZo=; b=05VrL5LEXo5x3mWKDX7vYwCtQjZ1gvzXZDIYjrlXqRRp9iWXJzutd6Ugc8O+Kc5JVYejqB Nlo6+xfC8UuFAeAg== Received: from kunlun.suse.cz (unknown [10.100.128.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 11E58A3B88; Mon, 11 Apr 2022 18:18:21 +0000 (UTC) Date: Mon, 11 Apr 2022 20:18:19 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Junio C Hamano Cc: =?iso-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason , Erik Cervin Edin , Christian Couder , jurgen_gjoncari@icloud.com, git Subject: Re: Make commit messages optional Message-ID: <20220411181819.GF163591@kunlun.suse.cz> References: <7ED89912-2E10-4356-9C61-14B90EC0719C@icloud.com> <220408.86r167bxra.gmgdl@evledraar.gmail.com> <220411.865ynfkj7r.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Apr 11, 2022 at 10:59:47AM -0700, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > On Fri, Apr 08 2022, Erik Cervin Edin wrote: > > > >> At the risk of bikeshedding. > >> > >> The case in favor of not allowing empty commit messages by default is > >> that most of the time, empty commit messages are useless. > >> > >> I've written my fair share of poor commit messages (-,..., wip, foo). > >> Sometimes I've fixed that retroactively, sometimes not. The advantage > >> I see with empty commit messages is that it's more ubiquitous to > >> "write something better" or "whatever". The downside is I can't git > >> log --grep '^$' to find them. > > > > You can: > > > > git log --invert-grep --grep '.' > > Wow, that's nasty. > > In any case, "--allow-empty-messages" exists, and that is where we > draw the line. We will not bend over backwards beyond it. Isn't special-casing the empty message bending over backwards to some other influence instead? Thanks Michal