From: Joel Holdsworth <jholdsworth@nvidia.com>
To: git@vger.kernel.org, "Luke Diamand" <luke@diamand.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com>,
Dorgon Chang <dorgonman@hotmail.com>,
Joachim Kuebart <joachim.kuebart@gmail.com>,
Daniel Levin <dendy.ua@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Ben Keene <seraphire@gmail.com>,
Andrew Oakley <andrew@adoakley.name>,
Joel Holdsworth <jholdsworth@nvidia.com>
Subject: [PATCH v5 09/22] git-p4: remove spaces around default arguments
Date: Fri, 1 Apr 2022 15:24:51 +0100 [thread overview]
Message-ID: <20220401142504.58995-10-jholdsworth@nvidia.com> (raw)
In-Reply-To: <20220401142504.58995-1-jholdsworth@nvidia.com>
PEP8 recommends that there should be no spaces around the = sign of
default argument values of functions.
This guideline is described here:
https://www.python.org/dev/peps/pep-0008/#other-recommendations
Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
---
git-p4.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index f8d07cfd7f..0353bca289 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1040,7 +1040,7 @@ def branch_exists(branch):
return out.rstrip() == branch
-def findUpstreamBranchPoint(head = "HEAD"):
+def findUpstreamBranchPoint(head="HEAD"):
branches = p4BranchesInGit()
# map from depot-path to branch name
branchByDepotPath = {}
@@ -1068,7 +1068,7 @@ def findUpstreamBranchPoint(head = "HEAD"):
return ["", settings]
-def createOrUpdateBranchesFromOrigin(localRefPrefix = "refs/remotes/p4/", silent=True):
+def createOrUpdateBranchesFromOrigin(localRefPrefix="refs/remotes/p4/", silent=True):
if not silent:
print("Creating/updating branch(es) in %s based on origin branch(es)"
% localRefPrefix)
@@ -2838,7 +2838,7 @@ def isPathWanted(self, path):
return True
return False
- def extractFilesFromCommit(self, commit, shelved=False, shelved_cl = 0):
+ def extractFilesFromCommit(self, commit, shelved=False, shelved_cl=0):
files = []
fnum = 0
while "depotFile%s" % fnum in commit:
@@ -3269,7 +3269,7 @@ def findShadowedFiles(self, files, change):
'rev': record['headRev'],
'type': record['headType']})
- def commit(self, details, files, branch, parent = "", allow_empty=False):
+ def commit(self, details, files, branch, parent="", allow_empty=False):
epoch = details["time"]
author = details["user"]
jobs = self.extractJobsFromCommit(details)
@@ -4415,8 +4415,8 @@ def main():
parser = optparse.OptionParser(cmd.usage.replace("%prog", "%prog " + cmdName),
options,
- description = cmd.description,
- formatter = HelpFormatter())
+ description=cmd.description,
+ formatter=HelpFormatter())
try:
(cmd, args) = parser.parse_args(sys.argv[2:], cmd)
--
2.35.GIT
next prev parent reply other threads:[~2022-04-01 16:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 14:24 [PATCH v5 00/22] git-p4: Various code tidy-ups Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 01/22] git-p4: add blank lines between functions and class definitions Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 02/22] git-p4: remove unneeded semicolons from statements Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 03/22] git-p4: indent with 4-spaces Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 04/22] git-p4: improve consistency of docstring formatting Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 05/22] git-p4: convert descriptive class and function comments into docstrings Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 06/22] git-p4: remove commented code Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 07/22] git-p4: sort and de-duplcate pylint disable list Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 08/22] git-p4: remove padding from lists, tuples and function arguments Joel Holdsworth
2022-04-01 14:24 ` Joel Holdsworth [this message]
2022-04-01 14:24 ` [PATCH v5 10/22] git-p4: removed brackets when assigning multiple return values Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 11/22] git-p4: place a single space after every comma Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 12/22] git-p4: remove extraneous spaces before function arguments Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 13/22] git-p4: remove redundant backslash-continuations inside brackets Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 14/22] git-p4: remove spaces between dictionary keys and colons Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 15/22] git-p4: ensure every comment has a single # Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 16/22] git-p4: ensure there is a single space around all operators Joel Holdsworth
2022-04-01 14:24 ` [PATCH v5 17/22] git-p4: normalize indentation of lines in conditionals Joel Holdsworth
2022-04-01 14:25 ` [PATCH v5 18/22] git-p4: compare to singletons with "is" and "is not" Joel Holdsworth
2022-04-01 14:25 ` [PATCH v5 19/22] git-p4: only seperate code blocks by a single empty line Joel Holdsworth
2022-04-01 14:25 ` [PATCH v5 20/22] git-p4: move inline comments to line above Joel Holdsworth
2022-04-01 14:25 ` [PATCH v5 21/22] git-p4: seperate multiple statements onto seperate lines Joel Holdsworth
2022-04-01 14:25 ` [PATCH v5 22/22] git-p4: sort imports Joel Holdsworth
2022-04-10 7:32 ` [PATCH v5 00/22] git-p4: Various code tidy-ups Tao Klerks
2022-04-11 19:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401142504.58995-10-jholdsworth@nvidia.com \
--to=jholdsworth@nvidia.com \
--cc=andrew@adoakley.name \
--cc=avarab@gmail.com \
--cc=dendy.ua@gmail.com \
--cc=dorgonman@hotmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joachim.kuebart@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=luke@diamand.org \
--cc=seraphire@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tzadik.vanderhoof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).