git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: git@vger.kernel.org
Cc: zoltan.klinger@gmail.com, Elijah Newren <newren@gmail.com>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Patrick Marlier <patrick.marlier@gmail.com>
Subject: [PATCH] clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd
Date: Thu, 10 Feb 2022 09:41:38 +0700	[thread overview]
Message-ID: <20220210024138.157327-1-bagasdotme@gmail.com> (raw)

Use past tense form of "to remove" and "to skip". This is especially
true when we had already removed an entry.

Link:
https://lore.kernel.org/git/CAKQMxzSQRL-Q5daxETF+gYhVScmq_n=r2LJAeEuxpM7=jPajZQ@mail.gmail.com/T/#u
Reported-by: Patrick Marlier <patrick.marlier@gmail.com>
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 builtin/clean.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/builtin/clean.c b/builtin/clean.c
index 3ff02bbbff..f1cd114ee2 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -30,13 +30,13 @@ static const char *const builtin_clean_usage[] = {
 	NULL
 };
 
-static const char *msg_remove = N_("Removing %s\n");
+static const char *msg_remove = N_("Removed %s\n");
 static const char *msg_would_remove = N_("Would remove %s\n");
-static const char *msg_skip_git_dir = N_("Skipping repository %s\n");
+static const char *msg_skip_git_dir = N_("Skipped repository %s\n");
 static const char *msg_would_skip_git_dir = N_("Would skip repository %s\n");
 static const char *msg_warn_remove_failed = N_("failed to remove %s");
 static const char *msg_warn_lstat_failed = N_("could not lstat %s\n");
-static const char *msg_skip_cwd = N_("Refusing to remove current working directory\n");
+static const char *msg_skip_cwd = N_("Refused to remove current working directory\n");
 static const char *msg_would_skip_cwd = N_("Would refuse to remove current working directory\n");
 
 enum color_clean {

base-commit: 2b9c1209706bc2ef0ab09fb0bdc7d405e225ce8b
-- 
An old man doll... just what I always wanted! - Clara


             reply	other threads:[~2022-02-10  2:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10  2:41 Bagas Sanjaya [this message]
2022-02-12  9:14 ` [PATCH] clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd Patrick Marlier
2022-02-12 22:29 ` Elijah Newren
2022-02-14 17:23   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210024138.157327-1-bagasdotme@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=patrick.marlier@gmail.com \
    --cc=zoltan.klinger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).