From: Joel Holdsworth <jholdsworth@nvidia.com>
To: git@vger.kernel.org, Luke Diamand <luke@diamand.org>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Cc: Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com>,
Dorgon Chang <dorgonman@hotmail.com>,
Joachim Kuebart <joachim.kuebart@gmail.com>,
Daniel Levin <dendy.ua@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Ben Keene <seraphire@gmail.com>,
Andrew Oakley <andrew@adoakley.name>,
Joel Holdsworth <jholdsworth@nvidia.com>
Subject: [PATCH v3 12/21] git-p4: remove extraneous spaces before function arguments
Date: Sun, 16 Jan 2022 16:05:41 +0000 [thread overview]
Message-ID: <20220116160550.514637-13-jholdsworth@nvidia.com> (raw)
In-Reply-To: <20220116160550.514637-1-jholdsworth@nvidia.com>
PEP8 recommends that there should be no spaces before function arguments
in the in the "Pet Peeves" section:
https://www.python.org/dev/peps/pep-0008/#pet-peeves
Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
---
git-p4.py | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 6a676cb415..c28edd9e85 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -969,16 +969,16 @@ def extractSettingsGitLog(log):
values = {}
for line in log.split("\n"):
line = line.strip()
- m = re.search (r"^ *\[git-p4: (.*)\]$", line)
+ m = re.search(r"^ *\[git-p4: (.*)\]$", line)
if not m:
continue
- assignments = m.group(1).split (':')
+ assignments = m.group(1).split(':')
for a in assignments:
- vals = a.split ('=')
+ vals = a.split('=')
key = vals[0].strip()
- val = ('='.join (vals[1:])).strip()
- if val.endswith ('\"') and val.startswith('"'):
+ val = ('='.join(vals[1:])).strip()
+ if val.endswith('\"') and val.startswith('"'):
val = val[1:-1]
values[key] = val
@@ -2333,9 +2333,9 @@ def applyCommit(self, id):
# Revert changes if we skip this patch
if not submitted or self.shelve:
if self.shelve:
- print ("Reverting shelved files.")
+ print("Reverting shelved files.")
else:
- print ("Submission cancelled, undoing p4 changes.")
+ print("Submission cancelled, undoing p4 changes.")
sys.stdout.flush()
for f in editedFiles | filesToDelete:
p4_revert(f)
@@ -4006,7 +4006,7 @@ def run(self, args):
i = i - 1
break
- paths.append ("/".join(cur_list[:i + 1]))
+ paths.append("/".join(cur_list[:i + 1]))
self.previousDepotPaths = paths
@@ -4035,8 +4035,8 @@ def run(self, args):
else:
if self.depotPaths and self.depotPaths != args:
print("previous import used depot path %s and now %s was specified. "
- "This doesn't work!" % (' '.join (self.depotPaths),
- ' '.join (args)))
+ "This doesn't work!" % (' '.join(self.depotPaths),
+ ' '.join(args)))
sys.exit(1)
self.depotPaths = sorted(args)
@@ -4076,7 +4076,7 @@ def run(self, args):
if len(self.changesFile) == 0:
revision = "#head"
- p = re.sub ("\.\.\.$", "", p)
+ p = re.sub("\.\.\.$", "", p)
if not p.endswith("/"):
p += "/"
--
2.34.1
next prev parent reply other threads:[~2022-01-16 16:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 16:05 [PATCH v3 00/21] git-p4: Various code tidy-ups Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 01/21] git-p4: add blank lines between functions and class definitions Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 02/21] git-p4: remove unneeded semicolons from statements Joel Holdsworth
2022-01-17 2:19 ` Junio C Hamano
2022-01-16 16:05 ` [PATCH v3 03/21] git-p4: indent with 4-spaces Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 04/21] git-p4: improve consistency of docstring formatting Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 05/21] git-p4: convert descriptive class and function comments into docstrings Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 06/21] git-p4: remove commented code Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 07/21] git-p4: sort and de-duplcate pylint disable list Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 08/21] git-p4: remove padding from lists, tuples and function arguments Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 09/21] git-p4: remove spaces around default arguments Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 10/21] git-p4: removed brackets when assigning multiple return values Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 11/21] git-p4: place a single space after every comma Joel Holdsworth
2022-01-16 16:05 ` Joel Holdsworth [this message]
2022-01-16 16:05 ` [PATCH v3 13/21] git-p4: remove redundant backslash-continuations inside brackets Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 14/21] git-p4: remove spaces between dictionary keys and colons Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 15/21] git-p4: ensure every comment has a single # Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 16/21] git-p4: ensure there is a single space around all operators Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 17/21] git-p4: normalize indentation of lines in conditionals Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 18/21] git-p4: compare to singletons with "is" and "is not" Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 19/21] git-p4: only seperate code blocks by a single empty line Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 20/21] git-p4: move inline comments to line above Joel Holdsworth
2022-01-16 16:05 ` [PATCH v3 21/21] git-p4: seperate multiple statements onto seperate lines Joel Holdsworth
2022-01-17 1:34 ` [PATCH v3 00/21] git-p4: Various code tidy-ups Junio C Hamano
2022-02-03 21:22 ` Joel Holdsworth
2022-02-03 21:30 ` Junio C Hamano
2022-02-04 12:27 ` Joel Holdsworth
2022-02-04 17:16 ` Junio C Hamano
2022-01-17 2:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220116160550.514637-13-jholdsworth@nvidia.com \
--to=jholdsworth@nvidia.com \
--cc=andrew@adoakley.name \
--cc=dendy.ua@gmail.com \
--cc=dorgonman@hotmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joachim.kuebart@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=luke@diamand.org \
--cc=seraphire@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tzadik.vanderhoof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).