From: Andrew Oakley <andrew@adoakley.name>
To: Joel Holdsworth <jholdsworth@nvidia.com>
Cc: git@vger.kernel.org,
Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com>,
Dorgon Chang <dorgonman@hotmail.com>,
Joachim Kuebart <joachim.kuebart@gmail.com>,
Daniel Levin <dendy.ua@gmail.com>,
Luke Diamand <luke@diamand.org>, Ben Keene <seraphire@gmail.com>
Subject: Re: [PATCH v3 RESEND 0/2] git-p4: remove "debug" and "rollback" verbs
Date: Tue, 4 Jan 2022 21:54:06 +0000 [thread overview]
Message-ID: <20220104215406.27298d62@ado-tr.dyn.home.arpa> (raw)
In-Reply-To: <20220104123431.1710-1-jholdsworth@nvidia.com>
On Tue, 4 Jan 2022 12:34:29 +0000
Joel Holdsworth <jholdsworth@nvidia.com> wrote:
> git-p4 contains a selection of verbs for various functions of the
> script. The "debug" and "rollback" verbs appear to have been added
> early in the development life of git-p4. They were once used as
> debugging tools, but are no longer being used either by developers or
> users, and are largely undocumented. Removing these verbs simplifies
> the script by removing dead code, and increases usability by reducing
> complexity.
I agree, these commands look rather usesless and I've never used them.
The patches to remove them look correct to me.
Thanks
prev parent reply other threads:[~2022-01-04 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 12:34 [PATCH v3 RESEND 0/2] git-p4: remove "debug" and "rollback" verbs Joel Holdsworth
2022-01-04 12:34 ` [PATCH v3 RESEND 1/2] git-p4: remove "debug" verb Joel Holdsworth
2022-01-04 12:34 ` [PATCH v3 RESEND 2/2] git-p4: remove "rollback" verb Joel Holdsworth
2022-01-04 21:54 ` Andrew Oakley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104215406.27298d62@ado-tr.dyn.home.arpa \
--to=andrew@adoakley.name \
--cc=dendy.ua@gmail.com \
--cc=dorgonman@hotmail.com \
--cc=git@vger.kernel.org \
--cc=jholdsworth@nvidia.com \
--cc=joachim.kuebart@gmail.com \
--cc=luke@diamand.org \
--cc=seraphire@gmail.com \
--cc=tzadik.vanderhoof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).