From: Jan Engelhardt <jengelh@inai.de>
To: git@vger.kernel.org
Subject: [PATCH 2/2] http-backend: give a hint that web browser access is not supported
Date: Thu, 2 Dec 2021 01:12:38 +0100 [thread overview]
Message-ID: <20211202001238.21808-2-jengelh@inai.de> (raw)
In-Reply-To: <20211202001238.21808-1-jengelh@inai.de>
Add a paragraph that browsing to http-backend is not something
that should normally be done
a webserver is configured to unconditionally pass requests
to git-http-backend, without any diversion to a gitweb frontend,
it is helpful to at least be told this.
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
---
http-backend.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git http-backend.c http-backend.c
index 8f1b69d127..06e17d45a4 100644
--- http-backend.c
+++ http-backend.c
@@ -775,8 +775,15 @@ int cmd_main(int argc, const char **argv)
regfree(&re);
}
- if (!cmd)
- not_found(&hdr, "Request not supported: '%s'", dir);
+ if (!cmd) {
+ const char *hint = "";
+ if (strcmp(method, "GET") == 0)
+ hint = "You cannot use regular web browsing to access "
+ "this URL. Only git operations like "
+ "clone/ls-remote/etc. will work.\n";
+ not_found(&hdr, "%s request not supported on '%s'.\n%s",
+ method, dir, hint);
+ }
setup_path();
if (!enter_repo(dir, 0))
--
2.34.0
next prev parent reply other threads:[~2021-12-02 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 0:12 [PATCH 1/2] http-backend: CGI error messages need to be output on stdout Jan Engelhardt
2021-12-02 0:12 ` Jan Engelhardt [this message]
2021-12-02 7:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202001238.21808-2-jengelh@inai.de \
--to=jengelh@inai.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).