git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Altmanninger <aclopte@gmail.com>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v2] sequencer: do not export GIT_DIR and GIT_WORK_TREE for 'exec'
Date: Tue, 16 Nov 2021 07:06:35 +0100	[thread overview]
Message-ID: <20211116060635.uy5ry5huwxo2hsxy@gmail.com> (raw)
In-Reply-To: <pull.1134.v2.git.git.1637041986945.gitgitgadget@gmail.com>

On Tue, Nov 16, 2021 at 05:53:06AM +0000, Elijah Newren via GitGitGadget wrote:
>     sequencer: fix environment that 'exec' commands run under
>     
>     Changes since v1:
>     
>      * Fix wording in multiple locations pointed out by Johannes
>        Altmanninger
>     
>     Note that Johaness Altmanninger also suggested some additional
>     GIT_DIR/GIT_WORK_TREE and --git-dir/--work-tree testcases, but since
>     those change the current working directory to the work tree so that
>     GIT_WORK_TREE ends up being '.' in every case, I think it's straying a
>     bit from the point of the test. If other feel strongly, I can add them
>     in.

Yeah I also think it's better to leave them out for now. For one, the
GIT_DIR/GIT_WORK_TREE test is not really interesting. Next, things are not so
obivous: I'm not sure if --git-dir/--work-tree should export those variables
to exec but that can be investigated later.

This patch looks great.

  reply	other threads:[~2021-11-16  6:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 17:42 [PATCH] sequencer: fix environment that 'exec' commands run under Elijah Newren via GitGitGadget
2021-11-14 20:21 ` Johannes Altmanninger
2021-11-23 17:48   ` Elijah Newren
2021-12-05  8:45     ` Johannes Altmanninger
2021-11-16  5:53 ` [PATCH v2] sequencer: do not export GIT_DIR and GIT_WORK_TREE for 'exec' Elijah Newren via GitGitGadget
2021-11-16  6:06   ` Johannes Altmanninger [this message]
2021-11-16  9:59   ` Phillip Wood
2021-12-04  5:36   ` [PATCH v3] " Elijah Newren via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116060635.uy5ry5huwxo2hsxy@gmail.com \
    --to=aclopte@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).