From: Thiago Perrotta <tbperrotta@gmail.com>
To: git@vger.kernel.org, carenas@gmail.com, gitster@pobox.com,
bagasdotme@gmail.com, avarab@gmail.com
Cc: tbperrotta@gmail.com
Subject: [PATCH v8 0/2] send-email: shell completion improvements
Date: Mon, 25 Oct 2021 17:27:05 -0400 [thread overview]
Message-ID: <20211025212707.188151-1-tbperrotta@gmail.com> (raw)
In-Reply-To: <87fst7lkjx.fsf@evledraar.gmail.com>
> ...I think that re-indentation is better left alone for the patch
> readability.
Reverted the `GetOptions` indentation. Noise is now gone :-)
> First, in your 1/3 you're adding a \n, but in 2/3 we end up with \n\n. I
> think you can just skip 1/3, maybe mention "how it also has a "\n" in
> the commit message.
I don't quite see how this would fit into the commit message. A comment in the
code seems to fit better to account for this detail. That's what I did, but if
you still disagree, please elaborate where in the commit message this sentence
should be added.
> You then strip out "--" arguments from the combined list, but isn't this
> something we do need to emit? I.e. it's used as syntax by the bash
> completion isn't it? (I just skimmed the relevant C code in
> parse-options.c).
I interpreted that standalone `--` as an extraneous / useless token. If it's
there intentionally, then I am reverting my stripping of it. At the end of the
day whether to include it or not is a small detail, but FYI, when I do:
$ git clone -<TAB>
in bash, nothing happens. I would have expected it to be expanded to "--"
because of the explicit "--", but it doesn't. Therefore my conclusion is that
"--" in the output of "--git-completion-helper" is useless. Am I missing
something? What would be the function of the standalone "--" then?
From my local testing, whether the options are sorted or not, whether
they are repeated or not, whether they follow a specific order with
respect to "--" or not, all of those details seem not to matter. Bash
completion seems to handle all of those cases just fine interactively.
In fact, here's another example:
$ git init --git-completion-helper | tr ' ' '\n' | grep -C1 '^--$'
--no-template
--
--no-bare
...there are --no-* options both _before_ and _after_ the --. I really
cannot see the point of the -- in the output, it seems to be just noise.
I readded -- to the output anyway since you requested it, but if it
needs to follow a certain spec w.r.t. ordering, we should have tests for
it. This specific part (the -- and the --no- order thing) of the commit
is something I am not keen to doing though, at least not in this patch
series; sorry, it already goes far beyond the scope of my original
intent. Anything else you ask for that is inline with the original
intent (like generating options programatically instead of hard-coding
them) I am fine with though, and in fact I believe I have addressed all
comments so far, if there's anything else I may have missed let me know.
> I.e. we should not simply strip the trailing "=" etc., we need to parse
> those out of the Perl GetOptions arguments, and come up with mapping to
> what we do in parse-options.c. I think that's basically adding a "=" at
> the end of all options that end with "=s", ":i", "=d", ":s" etc.
OK, I see. This is a valid point, I updated the code to reflect this desired
behavior. PTAL. If needed we could make it more DRY, but as it is now it
seems quite readable.
> We then don't want to emit "-h", but you strip out "--h", first we
> mapped "h" to "--h" in the loop above, so we should do that there. But
> better yet we have a "%dump_aliases_options" already, maybe it +
> "git-completion-helper" can be moved to another "%not_for_completion"
> hash or something.
OK, done. Introduced a "not_for_completion" hash. Doesn't seem to make a
huge difference compared to just using `grep` though.
Differences from V7:
As per Ævar's comments:
- completely drop 1/3 since we'now using split instead of print to incorporate
format-patch options. Side effect: then-extraneous '\n' is now gone.
- revert indentation (tabs) on GetOptions to eliminate diff noise (as per Ævar's
interpretation of original Carlos's comment)
- re-add "--" to the output of "git send-email --git-completion-helper"
- introduce a "not_for_completion" hash to remove undesired options from the
output
- add trailing = to send-email options that expect a string or an integer
argument, consistently with format-patch options
Thiago Perrotta (2):
send-email: programmatically generate bash completions
send-email docs: add format-patch options
Documentation/git-send-email.txt | 6 ++-
contrib/completion/git-completion.bash | 11 +----
git-send-email.perl | 56 +++++++++++++++++++++-----
t/t9902-completion.sh | 3 ++
4 files changed, 54 insertions(+), 22 deletions(-)
--
2.33.1
next prev parent reply other threads:[~2021-10-25 21:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 0:46 [PATCH v2 0/3] send-email: shell completion improvements Thiago Perrotta
2021-08-20 0:46 ` [PATCH v2 1/3] send-email: print newline for --git-completion-helper Thiago Perrotta
2021-08-20 20:17 ` Junio C Hamano
2021-08-28 3:08 ` [PATCH v3 0/3] send-email: shell completion improvements Thiago Perrotta
2021-08-28 3:08 ` [PATCH v3 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-08-28 3:08 ` [PATCH v3 2/3] send-email: move bash completions to core script Thiago Perrotta
2021-08-28 5:25 ` Carlo Arenas
2021-09-07 0:16 ` [PATCH] " Thiago Perrotta
2021-09-07 1:28 ` Carlo Arenas
2021-09-21 15:51 ` [PATCH v4 0/3] send-email: shell completion improvements Thiago Perrotta
2021-09-21 15:51 ` [PATCH v4 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-09-21 15:51 ` [PATCH v4 2/3] send-email: move bash completions to core script Thiago Perrotta
2021-09-21 15:51 ` [PATCH v4 3/3] send-email docs: add format-patch options Thiago Perrotta
2021-09-23 14:02 ` [PATCH v4 0/3] send-email: shell completion improvements Ævar Arnfjörð Bjarmason
2021-09-24 2:46 ` [PATCH v5 " Thiago Perrotta
2021-09-24 20:02 ` Ævar Arnfjörð Bjarmason
2021-09-30 3:10 ` Thiago Perrotta
2021-10-07 3:36 ` [PATCH v6 " Thiago Perrotta
2021-10-07 3:36 ` [PATCH v6 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-10-07 3:36 ` [PATCH v6 2/3] send-email: programmatically generate bash completions Thiago Perrotta
2021-10-09 6:38 ` Carlo Marcelo Arenas Belón
2021-10-11 4:10 ` [PATCH v7 0/3] send-email: shell completion improvements Thiago Perrotta
2021-10-11 13:46 ` Ævar Arnfjörð Bjarmason
2021-10-11 17:12 ` [DRAFT/WIP PATCH] send-email: programmatically generate bash completions Thiago Perrotta
2021-10-25 21:27 ` Thiago Perrotta [this message]
2021-10-25 22:44 ` [PATCH v8 0/2] send-email: shell completion improvements Ævar Arnfjörð Bjarmason
2021-10-26 0:48 ` Ævar Arnfjörð Bjarmason
2021-10-28 16:31 ` Junio C Hamano
2021-10-25 21:27 ` [PATCH v8 1/2] send-email: programmatically generate bash completions Thiago Perrotta
2021-10-25 21:27 ` [PATCH v8 2/2] send-email docs: add format-patch options Thiago Perrotta
2021-10-11 4:10 ` [PATCH v7 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-10-11 4:10 ` [PATCH v7 2/3] send-email: programmatically generate bash completions Thiago Perrotta
2021-10-11 4:10 ` [PATCH v7 3/3] send-email docs: add format-patch options Thiago Perrotta
2021-10-07 3:36 ` [PATCH v6 " Thiago Perrotta
2021-10-09 8:31 ` [RFC PATCH] Documentation: better document format-patch options in send-email Carlo Marcelo Arenas Belón
2021-10-09 8:57 ` Bagas Sanjaya
2021-10-09 9:32 ` Carlo Arenas
2021-10-09 11:04 ` Bagas Sanjaya
2021-10-10 21:33 ` Junio C Hamano
2021-09-24 2:46 ` [PATCH v5 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-09-24 2:46 ` [PATCH v5 2/3] send-email: programmatically generate bash completions Thiago Perrotta
2021-09-24 2:46 ` [PATCH v5 3/3] send-email docs: add format-patch options Thiago Perrotta
2021-09-24 4:36 ` Bagas Sanjaya
2021-09-24 4:53 ` Carlo Arenas
2021-09-24 6:19 ` Bagas Sanjaya
2021-09-24 6:56 ` Carlo Arenas
2021-09-24 15:33 ` Junio C Hamano
2021-09-24 17:34 ` Carlo Arenas
2021-09-24 20:03 ` Junio C Hamano
2021-09-25 3:03 ` Bagas Sanjaya
2021-09-25 4:07 ` Junio C Hamano
2021-09-25 6:13 ` Carlo Marcelo Arenas Belón
2021-09-29 21:20 ` Junio C Hamano
2021-08-28 3:08 ` [PATCH v3 " Thiago Perrotta
2021-08-28 5:22 ` Bagas Sanjaya
2021-08-20 0:46 ` [PATCH v2 2/3] send-email: move bash completions to the perl script Thiago Perrotta
2021-08-20 0:46 ` [PATCH v2 3/3] send-email docs: mention format-patch options Thiago Perrotta
2021-08-20 20:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025212707.188151-1-tbperrotta@gmail.com \
--to=tbperrotta@gmail.com \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).