From: Bagas Sanjaya <bagasdotme@gmail.com>
To: git@vger.kernel.org
Cc: Glen Choo <chooglen@google.com>,
Junio C Hamano <gitster@pobox.com>,
Carlo Arenas <carenas@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: [PATCH] Documentation: specify base point when generating MyFirstContribution patchset
Date: Wed, 13 Oct 2021 19:22:35 +0700 [thread overview]
Message-ID: <20211013122234.448845-1-bagasdotme@gmail.com> (raw)
Some reviewers need to know the base point of patchset a contributor
being worked on. Mention how to answer that.
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Documentation/MyFirstContribution.txt | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt
index b20bc8e914..081fb71327 100644
--- a/Documentation/MyFirstContribution.txt
+++ b/Documentation/MyFirstContribution.txt
@@ -937,6 +937,13 @@ but want reviewers to look at what they have so far. You can add this flag with
Check and make sure that your patches and cover letter template exist in the
directory you specified - you're nearly ready to send out your review!
+Some reviewers (notably testers) would like to know at what point your patchset
+are based on (in particular to apply the patchset). In such cases, you can
+mention the base point when preparing your email (see below section), or by
+passing `--base=$(git merge-base master psuh)` to `format-patch`. If no base
+point is specified, the patchset is assumed to be applied on top of current
+tip of `master` branch.
+
[[cover-letter]]
=== Preparing Email
base-commit: 106298f7f9cca4158a980de149ef217751e1f943
--
An old man doll... just what I always wanted! - Clara
next reply other threads:[~2021-10-13 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 12:22 Bagas Sanjaya [this message]
2021-10-13 20:30 ` [PATCH] Documentation: specify base point when generating MyFirstContribution patchset Junio C Hamano
2021-10-15 6:51 ` Bagas Sanjaya
2021-10-15 16:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013122234.448845-1-bagasdotme@gmail.com \
--to=bagasdotme@gmail.com \
--cc=carenas@gmail.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).