From: Atharva Raykar <raykar.ath@gmail.com>
To: raykar.ath@gmail.com
Cc: avarab@gmail.com, christian.couder@gmail.com,
emilyshaffer@google.com, git@vger.kernel.org, gitster@pobox.com,
jrnieder@gmail.com, kaartic.sivaraam@gmail.com,
pc44800@gmail.com, periperidip@gmail.com
Subject: [PATCH v3 0/9] submodule: convert the rest of 'update' to C
Date: Wed, 13 Oct 2021 10:47:56 +0530 [thread overview]
Message-ID: <20211013051805.45662-1-raykar.ath@gmail.com> (raw)
In-Reply-To: <20210916103241.62376-1-raykar.ath@gmail.com>
Since v2:
- Rebased this series on top of a more up-to-date master branch.
- Reorganized this series to (hopefully) make it easier to review, as per
Junio's suggestions. I split up the patch that converts the rest of the
update shell script to C into multiple steps. I also squashed the patches
that removed unused helpers, as there was not clear criteria for it being two
patches.
- Plugged a memory leak while refactoring sync_submodule() to use my new
helper.
Note on conflicting series:
--------------------------
This series currently conflicts with the work being done by Emily in
'es/superproject-aware-submodules' [1], mainly in the part where they cache the
superproject gitdir in the shell script that gets removed during conversion in
this series.
I have attempted to make a version of this series that is based on that topic [2],
and added the superproject gitdir caching code in C [3]. It passes the tests,
but I am not too confident about its correctness. I hope that branch can be
helpful in some way.
[1] https://lore.kernel.org/git/20210819200953.2105230-1-emilyshaffer@google.com/
[2] https://github.com/tfidfwastaken/git/commits/submodule-update-on-es-superproject-aware
(fetch-it-via: git fetch https://github.com/tfidfwastaken/git submodule-update-on-es-superproject-aware)
[3] https://github.com/tfidfwastaken/git/blob/a74aaf2540c536970f2541d3042c825f82a69770/builtin/submodule--helper.c#L2922-L2930
Fetch-it-Via:
git fetch https://github.com/tfidfwastaken/git submodule-update-list-3
Atharva Raykar (9):
submodule--helper: split up ensure_core_worktree()
submodule--helper: get remote names from any repository
submodule--helper: rename helpers for update-clone
submodule--helper: refactor get_submodule_displaypath()
submodule--helper: allow setting superprefix for init_submodule()
submodule--helper: run update using child process struct
submodule: move core cmd_update() logic to C
submodule--helper: remove unused helpers
submodule--helper: rename helper functions
builtin/submodule--helper.c | 771 +++++++++++++++++++++---------------
git-submodule.sh | 145 +------
2 files changed, 458 insertions(+), 458 deletions(-)
Range diff against the previous version:
1: f83a5b7f34 ! 1: d057ba04bd submodule--helper: split up ensure_core_worktree()
@@ builtin/submodule--helper.c: static int push_check(int argc, const char **argv,
-static int ensure_core_worktree(int argc, const char **argv, const char *prefix)
+static void do_ensure_core_worktree(const char *path)
{
- const struct submodule *sub;
- const char *path;
const char *cw;
struct repository subrepo;
@@ builtin/submodule--helper.c: static int push_check(int argc, const char **argv,
-
- path = argv[1];
-
- sub = submodule_from_path(the_repository, null_oid(), path);
- if (!sub)
- BUG("We could get the submodule handle before?");
+ if (repo_submodule_init(&subrepo, the_repository, path, null_oid()))
+ die(_("could not get a repository handle for submodule '%s'"), path);
+
@@ builtin/submodule--helper.c: static int ensure_core_worktree(int argc, const char **argv, const char *prefix)
free(abs_path);
strbuf_release(&sb);
2: 7f4e24ce25 ! 2: 895cc10b97 submodule--helper: get remote names from any repository
@@ builtin/submodule--helper.c: static char *get_default_remote(void)
+static char *get_default_remote_submodule(const char *module_path)
+{
+ const char *refname;
-+ const struct submodule *sub;
+ struct repository subrepo;
+
+ refname = refs_resolve_ref_unsafe(get_submodule_ref_store(module_path),
+ "HEAD", 0, NULL, NULL);
-+ sub = submodule_from_path(the_repository, null_oid(), module_path);
-+ repo_submodule_init(&subrepo, the_repository, sub);
++ repo_submodule_init(&subrepo, the_repository, module_path, null_oid());
+ return repo_get_default_remote(&subrepo, refname);
+}
+
@@ builtin/submodule--helper.c: static char *get_default_remote(void)
{
char *remote;
@@ builtin/submodule--helper.c: static void sync_submodule(const char *path, const char *prefix,
+ {
+ const struct submodule *sub;
char *remote_key = NULL;
- char *sub_origin_url, *super_config_url, *displaypath;
+- char *sub_origin_url, *super_config_url, *displaypath;
++ char *sub_origin_url, *super_config_url, *displaypath, *default_remote;
struct strbuf sb = STRBUF_INIT;
- struct child_process cp = CHILD_PROCESS_INIT;
char *sub_config_path = NULL;
@@ builtin/submodule--helper.c: static void sync_submodule(const char *path, const
-
strbuf_reset(&sb);
- if (capture_command(&cp, &sb, 0))
-+ strbuf_addstr(&sb, get_default_remote_submodule(path));
-+ if (!sb.buf)
++ default_remote = get_default_remote_submodule(path);
++ if (!default_remote)
die(_("failed to get the default remote for submodule '%s'"),
path);
+- strbuf_strip_suffix(&sb, "\n");
+- remote_key = xstrfmt("remote.%s.url", sb.buf);
++ remote_key = xstrfmt("remote.%s.url", default_remote);
++ free(default_remote);
+
+- strbuf_reset(&sb);
+ submodule_to_gitdir(&sb, path);
+ strbuf_addstr(&sb, "/config");
+
3: 390596ee7c = 3: 1defe3e0ca submodule--helper: rename helpers for update-clone
4: 2a2ddcac91 = 4: 693b23772a submodule--helper: refactor get_submodule_displaypath()
-: ---------- > 5: d1fd902a2a submodule--helper: allow setting superprefix for init_submodule()
-: ---------- > 6: 19c6c4e81a submodule--helper: run update using child process struct
5: 832020a290 ! 7: 7cc32ad6f9 submodule: move core cmd_update() logic to C
@@ Commit message
new subprocess and call `submodule--helper init` on the submodule paths,
because the Git machinery is not able to pick up the configuration
changes introduced by that init call[1]. So we instead run the
- `init_submodule_cb()` callback over each submodule directly.
-
- This introduces another problem, because there is no mechanism to pass
- the superproject path prefix (ie, `--super-prefix`) without starting a
- new git process. This field is required for obtaining the display path
- for that is used by the command's output messages. So let's add a field
- into the `init_cb` struct that lets us pass this information to
- `init_submodule()`, which will now also take an explicit 'superprefix'
- argument.
+ `init_submodule_cb()` callback over each submodule in the same process.
While we are at it, we also remove the fetch_in_submodule() shell
function since it is no longer used anywhere.
@@ Commit message
Signed-off-by: Atharva Raykar <raykar.ath@gmail.com>
## builtin/submodule--helper.c ##
-@@ builtin/submodule--helper.c: static char *compute_submodule_clone_url(const char *rel_url)
-
- struct init_cb {
- const char *prefix;
-+ const char *superprefix;
- unsigned int flags;
- };
--#define INIT_CB_INIT { NULL, 0 }
-+#define INIT_CB_INIT { 0 }
-
- static void init_submodule(const char *path, const char *prefix,
-- unsigned int flags)
-+ const char *superprefix, unsigned int flags)
- {
- const struct submodule *sub;
- struct strbuf sb = STRBUF_INIT;
- char *upd = NULL, *url = NULL, *displaypath;
-
-- displaypath = get_submodule_displaypath(path, prefix);
-+ /* try superprefix from the environment, if it is not passed explicitly */
-+ if (!superprefix)
-+ superprefix = get_super_prefix();
-+ displaypath = do_get_submodule_displaypath(path, prefix, superprefix);
-
- sub = submodule_from_path(the_repository, null_oid(), path);
-
-@@ builtin/submodule--helper.c: static void init_submodule(const char *path, const char *prefix,
- static void init_submodule_cb(const struct cache_entry *list_item, void *cb_data)
- {
- struct init_cb *info = cb_data;
-- init_submodule(list_item->name, info->prefix, info->flags);
-+ init_submodule(list_item->name, info->prefix, info->superprefix, info->flags);
- }
-
- static int module_init(int argc, const char **argv, const char *prefix)
@@ builtin/submodule--helper.c: struct submodule_update_clone {
const char *prefix;
int single_branch;
@@ builtin/submodule--helper.c: static int fetch_in_submodule(const char *module_pa
-static int run_update_command(struct update_data *ud, int subforce)
+static int run_update_command(struct update_data *ud, int subforce, struct string_list *err)
{
-- struct strvec args = STRVEC_INIT;
-- struct strvec child_env = STRVEC_INIT;
-+ struct child_process cp = CHILD_PROCESS_INIT;
+ struct child_process cp = CHILD_PROCESS_INIT;
char *oid = oid_to_hex(&ud->oid);
+ struct strbuf out = STRBUF_INIT;
int must_die_on_failure = 0;
-- int git_cmd;
+ struct submodule_update_strategy strategy = SUBMODULE_UPDATE_STRATEGY_INIT;
-+
+
+- switch (ud->update_strategy.type) {
+ if (ud->update_strategy.type == SM_UPDATE_UNSPECIFIED || ud->just_cloned)
+ determine_submodule_update_strategy(the_repository, ud->just_cloned,
+ ud->sm_path, NULL, &strategy);
+ else
+ strategy = ud->update_strategy;
-
-- switch (ud->update_strategy.type) {
-+ cp.dir = xstrdup(ud->sm_path);
++
+ switch (strategy.type) {
case SM_UPDATE_CHECKOUT:
-- git_cmd = 1;
-- strvec_pushl(&args, "checkout", "-q", NULL);
-+ cp.git_cmd = 1;
-+ strvec_pushl(&cp.args, "checkout", "-q", NULL);
- if (subforce)
-- strvec_push(&args, "-f");
-+ strvec_push(&cp.args, "-f");
- break;
- case SM_UPDATE_REBASE:
-- git_cmd = 1;
-- strvec_push(&args, "rebase");
-+ cp.git_cmd = 1;
-+ strvec_push(&cp.args, "rebase");
- if (ud->quiet)
-- strvec_push(&args, "--quiet");
-+ strvec_push(&cp.args, "--quiet");
- must_die_on_failure = 1;
- break;
- case SM_UPDATE_MERGE:
-- git_cmd = 1;
-- strvec_push(&args, "merge");
-+ cp.git_cmd = 1;
-+ strvec_push(&cp.args, "merge");
- if (ud->quiet)
-- strvec_push(&args, "--quiet");
-+ strvec_push(&cp.args, "--quiet");
- must_die_on_failure = 1;
+ cp.git_cmd = 1;
+ strvec_pushl(&cp.args, "checkout", "-q", NULL);
+@@ builtin/submodule--helper.c: static int run_update_command(struct update_data *ud, int subforce)
break;
case SM_UPDATE_COMMAND:
-- git_cmd = 0;
-- strvec_push(&args, ud->update_strategy.command);
-+ cp.git_cmd = 0;
-+ cp.use_shell = 1;
+ cp.use_shell = 1;
+- strvec_push(&cp.args, ud->update_strategy.command);
+ strvec_push(&cp.args, strategy.command);
must_die_on_failure = 1;
break;
@@ builtin/submodule--helper.c: static int fetch_in_submodule(const char *module_pa
- submodule_strategy_to_string(&ud->update_strategy));
+ submodule_strategy_to_string(&strategy));
}
-- strvec_push(&args, oid);
-+ strvec_push(&cp.args, oid);
+ strvec_push(&cp.args, oid);
-- prepare_submodule_repo_env(&child_env);
-- if (run_command_v_opt_cd_env(args.v, git_cmd ? RUN_GIT_CMD : RUN_USING_SHELL,
-- ud->sm_path, child_env.v)) {
+ cp.dir = xstrdup(ud->sm_path);
+ prepare_submodule_repo_env(&cp.env_array);
+- if (run_command(&cp)) {
- switch (ud->update_strategy.type) {
-+ prepare_submodule_repo_env(&cp.env_array);
+ if (capture_command(&cp, &out, 0)) {
+ if (must_die_on_failure) {
+ switch (strategy.type) {
@@ builtin/submodule--helper.c: static int module_set_branch(int argc, const char *
struct add_data {
const char *prefix;
const char *branch;
-@@ builtin/submodule--helper.c: static int add_clone(int argc, const char **argv, const char *prefix)
+@@ builtin/submodule--helper.c: static int module_add(int argc, const char **argv, const char *prefix)
return 0;
}
@@ builtin/submodule--helper.c: static int add_clone(int argc, const char **argv, c
@@ builtin/submodule--helper.c: static struct cmd_struct commands[] = {
{"name", module_name, 0},
{"clone", module_clone, 0},
- {"add-clone", add_clone, 0},
+ {"add", module_add, SUPPORT_SUPER_PREFIX},
+ {"update", module_update, 0},
{"update-module-mode", module_update_module_mode, 0},
{"update-clone", update_clone, 0},
6: fb3fa8174a < -: ---------- submodule--helper: remove update-clone subcommand
7: 364f72f870 ! 8: 486f9d0a0e submodule--helper: remove unused helpers
@@ Commit message
These helpers were useful back when 'submodule update' had most of its
logic in shell. Now that they will never be invoked, let us remove them.
+ We also no longer need the 'update_clone_submodules()' and
+ 'update_clone_submodule()' functions, so we remove those as well.
+
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Shourya Shukla <periperidip@gmail.com>
Signed-off-by: Atharva Raykar <raykar.ath@gmail.com>
@@ builtin/submodule--helper.c: static int do_run_update_procedure(struct update_da
return run_update_command(ud, subforce, err);
}
+-static void update_clone_submodule(struct update_clone_data *ucd)
+-{
+- fprintf(stdout, "dummy %s %d\t%s\n",
+- oid_to_hex(&ucd->oid),
+- ucd->just_cloned,
+- ucd->sub->path);
+-}
+-
+-static int update_clone_submodules(struct submodule_update_clone *suc)
+-{
+- int i;
+-
+- run_processes_parallel_tr2(suc->max_jobs, update_clone_get_next_task,
+- update_clone_start_failure,
+- update_clone_task_finished, suc, "submodule",
+- "parallel/update");
+-
+- /*
+- * We saved the output and put it out all at once now.
+- * That means:
+- * - the listener does not have to interleave their (checkout)
+- * work with our fetching. The writes involved in a
+- * checkout involve more straightforward sequential I/O.
+- * - the listener can avoid doing any work if fetching failed.
+- */
+- if (suc->quickstop)
+- return 1;
+-
+- for (i = 0; i < suc->update_clone_nr; i++)
+- update_clone_submodule(&suc->update_clone[i]);
+-
+- return 0;
+-}
+-
+-static int update_clone(int argc, const char **argv, const char *prefix)
+-{
+- const char *update = NULL;
+- struct pathspec pathspec;
+- struct submodule_update_clone suc = SUBMODULE_UPDATE_CLONE_INIT;
+-
+- struct option module_update_clone_options[] = {
+- OPT_STRING(0, "prefix", &prefix,
+- N_("path"),
+- N_("path into the working tree")),
+- OPT_STRING(0, "recursive-prefix", &suc.recursive_prefix,
+- N_("path"),
+- N_("path into the working tree, across nested "
+- "submodule boundaries")),
+- OPT_STRING(0, "update", &update,
+- N_("string"),
+- N_("rebase, merge, checkout or none")),
+- OPT_STRING_LIST(0, "reference", &suc.references, N_("repo"),
+- N_("reference repository")),
+- OPT_BOOL(0, "dissociate", &suc.dissociate,
+- N_("use --reference only while cloning")),
+- OPT_STRING(0, "depth", &suc.depth, "<depth>",
+- N_("create a shallow clone truncated to the "
+- "specified number of revisions")),
+- OPT_INTEGER('j', "jobs", &suc.max_jobs,
+- N_("parallel jobs")),
+- OPT_BOOL(0, "recommend-shallow", &suc.recommend_shallow,
+- N_("whether the initial clone should follow the shallow recommendation")),
+- OPT__QUIET(&suc.quiet, N_("don't print cloning progress")),
+- OPT_BOOL(0, "progress", &suc.progress,
+- N_("force cloning progress")),
+- OPT_BOOL(0, "require-init", &suc.require_init,
+- N_("disallow cloning into non-empty directory")),
+- OPT_BOOL(0, "single-branch", &suc.single_branch,
+- N_("clone only one branch, HEAD or --branch")),
+- OPT_END()
+- };
+-
+- const char *const git_submodule_helper_usage[] = {
+- N_("git submodule--helper update-clone [--prefix=<path>] [<path>...]"),
+- NULL
+- };
+- suc.prefix = prefix;
+-
+- update_clone_config_from_gitmodules(&suc.max_jobs);
+- git_config(git_update_clone_config, &suc.max_jobs);
+-
+- argc = parse_options(argc, argv, prefix, module_update_clone_options,
+- git_submodule_helper_usage, 0);
+-
+- if (update)
+- if (parse_submodule_update_strategy(update, &suc.update) < 0)
+- die(_("bad value for update parameter"));
+-
+- if (module_list_compute(argc, argv, prefix, &pathspec, &suc.list) < 0)
+- return 1;
+-
+- if (pathspec.nr)
+- suc.warn_if_uninitialized = 1;
+-
+- return update_clone_submodules(&suc);
+-}
+-
-static int run_update_procedure(int argc, const char **argv, const char *prefix)
-{
- int force = 0, quiet = 0, nofetch = 0, just_cloned = 0;
@@ builtin/submodule--helper.c: static void do_ensure_core_worktree(const char *pat
int i;
@@ builtin/submodule--helper.c: static struct cmd_struct commands[] = {
{"clone", module_clone, 0},
- {"add-clone", add_clone, 0},
+ {"add", module_add, SUPPORT_SUPER_PREFIX},
{"update", module_update, 0},
- {"update-module-mode", module_update_module_mode, 0},
+- {"update-clone", update_clone, 0},
- {"run-update-procedure", run_update_procedure, 0},
- {"ensure-core-worktree", ensure_core_worktree, 0},
- {"relative-path", resolve_relative_path, 0},
- {"resolve-relative-url", resolve_relative_url, 0},
{"resolve-relative-url-test", resolve_relative_url_test, 0},
{"foreach", module_foreach, SUPPORT_SUPER_PREFIX},
{"init", module_init, SUPPORT_SUPER_PREFIX},
8: ca48dd452c ! 9: 7b5b2be1a0 submodule--helper: rename helper functions
@@ builtin/submodule--helper.c: static int push_check(int argc, const char **argv,
-static void do_ensure_core_worktree(const char *path)
+static void ensure_core_worktree(const char *path)
{
- const struct submodule *sub;
const char *cw;
+ struct repository subrepo;
@@ builtin/submodule--helper.c: static int update_submodule(struct update_data *update_data)
char *prefixed_path;
struct string_list err = STRING_LIST_INIT_DUP;
--
2.32.0
next prev parent reply other threads:[~2021-10-13 5:18 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 11:59 [PATCH 00/13] submodule: convert the rest of 'update' to C Atharva Raykar
2021-09-07 11:59 ` [PATCH 01/13] submodule--helper: split up ensure_core_worktree() Atharva Raykar
2021-09-07 11:59 ` [PATCH 02/13] submodule--helper: get remote names from any repository Atharva Raykar
2021-09-07 12:37 ` Ævar Arnfjörð Bjarmason
2021-09-07 13:33 ` Atharva Raykar
2021-09-07 11:59 ` [PATCH 03/13] submodule--helper: introduce get_default_remote_submodule() Atharva Raykar
2021-09-07 11:59 ` [PATCH 04/13] submodule--helper: rename helpers for update-clone Atharva Raykar
2021-09-07 11:59 ` [PATCH 05/13] submodule--helper: refactor get_submodule_displaypath() Atharva Raykar
2021-09-07 11:59 ` [PATCH 06/13] submodule: move core cmd_update() logic to C Atharva Raykar
2021-09-07 12:40 ` Ævar Arnfjörð Bjarmason
2021-09-07 11:59 ` [PATCH 07/13] submodule: remove fetch_in_submodule shell function Atharva Raykar
2021-09-07 12:44 ` Ævar Arnfjörð Bjarmason
2021-09-07 11:59 ` [PATCH 08/13] submodule--helper: remove update-clone subcommand Atharva Raykar
2021-09-07 12:46 ` Ævar Arnfjörð Bjarmason
2021-09-07 11:59 ` [PATCH 09/13] submodule--helper: remove update-module-mode subcommand Atharva Raykar
2021-09-07 12:49 ` Ævar Arnfjörð Bjarmason
2021-09-07 13:50 ` Atharva Raykar
2021-09-07 11:59 ` [PATCH 10/13] submodule--helper: remove shell interface to ensure_core_worktree() Atharva Raykar
2021-09-07 11:59 ` [PATCH 11/13] submodule--helper: remove print-default-remote subcommand Atharva Raykar
2021-09-07 11:59 ` [PATCH 12/13] submodule--helper: remove relative-path subcommand Atharva Raykar
2021-09-07 11:59 ` [PATCH 13/13] submodule--helper: remove run-update-procedure subcommand Atharva Raykar
2021-09-07 12:34 ` [PATCH 00/13] submodule: convert the rest of 'update' to C Ævar Arnfjörð Bjarmason
2021-09-07 12:53 ` Atharva Raykar
2021-09-16 10:32 ` [PATCH v2 0/8] " Atharva Raykar
2021-09-16 10:32 ` [PATCH v2 1/8] submodule--helper: split up ensure_core_worktree() Atharva Raykar
2021-09-16 10:32 ` [PATCH v2 2/8] submodule--helper: get remote names from any repository Atharva Raykar
2021-09-20 16:52 ` Junio C Hamano
2021-10-03 13:22 ` Atharva Raykar
2021-09-20 21:28 ` Junio C Hamano
2021-09-21 16:33 ` Jonathan Tan
2021-09-16 10:32 ` [PATCH v2 3/8] submodule--helper: rename helpers for update-clone Atharva Raykar
2021-09-16 10:32 ` [PATCH v2 4/8] submodule--helper: refactor get_submodule_displaypath() Atharva Raykar
2021-09-16 10:32 ` [PATCH v2 5/8] submodule: move core cmd_update() logic to C Atharva Raykar
2021-09-20 17:13 ` Junio C Hamano
2021-10-03 10:38 ` Atharva Raykar
2021-09-20 19:58 ` Junio C Hamano
2021-09-20 21:28 ` Junio C Hamano
2021-09-16 10:32 ` [PATCH v2 6/8] submodule--helper: remove update-clone subcommand Atharva Raykar
2021-09-16 10:32 ` [PATCH v2 7/8] submodule--helper: remove unused helpers Atharva Raykar
2021-09-20 17:19 ` Junio C Hamano
2021-09-16 10:32 ` [PATCH v2 8/8] submodule--helper: rename helper functions Atharva Raykar
2021-09-20 17:19 ` Junio C Hamano
2021-10-13 5:17 ` Atharva Raykar [this message]
2021-10-13 5:17 ` [PATCH v3 1/9] submodule--helper: split up ensure_core_worktree() Atharva Raykar
2021-10-13 5:17 ` [PATCH v3 2/9] submodule--helper: get remote names from any repository Atharva Raykar
2021-10-13 5:17 ` [PATCH v3 3/9] submodule--helper: rename helpers for update-clone Atharva Raykar
2021-10-13 5:18 ` [PATCH v3 4/9] submodule--helper: refactor get_submodule_displaypath() Atharva Raykar
2021-10-13 5:18 ` [PATCH v3 5/9] submodule--helper: allow setting superprefix for init_submodule() Atharva Raykar
2021-10-13 5:18 ` [PATCH v3 6/9] submodule--helper: run update using child process struct Atharva Raykar
2021-10-13 5:18 ` [PATCH v3 7/9] submodule: move core cmd_update() logic to C Atharva Raykar
2021-10-13 5:18 ` [PATCH v3 8/9] submodule--helper: remove unused helpers Atharva Raykar
2021-10-13 5:18 ` [PATCH v3 9/9] submodule--helper: rename helper functions Atharva Raykar
2021-10-14 0:05 ` [PATCH v3 0/9] submodule: convert the rest of 'update' to C Junio C Hamano
2021-10-14 20:46 ` Emily Shaffer
2021-12-03 19:00 ` Junio C Hamano
2021-12-03 20:15 ` Ævar Arnfjörð Bjarmason
2021-12-04 10:38 ` Atharva Raykar
2022-01-27 16:22 ` [PATCH v4 0/7] " Ævar Arnfjörð Bjarmason
2022-01-27 16:22 ` [PATCH v4 1/7] submodule--helper: get remote names from any repository Ævar Arnfjörð Bjarmason
2022-01-27 18:45 ` Glen Choo
2022-01-27 16:22 ` [PATCH v4 2/7] submodule--helper: refactor get_submodule_displaypath() Ævar Arnfjörð Bjarmason
2022-01-27 16:22 ` [PATCH v4 3/7] submodule--helper: allow setting superprefix for init_submodule() Ævar Arnfjörð Bjarmason
2022-01-27 16:22 ` [PATCH v4 4/7] submodule--helper: run update using child process struct Ævar Arnfjörð Bjarmason
2022-01-27 16:22 ` [PATCH v4 5/7] builtin/submodule--helper.c: reformat designated initializers Ævar Arnfjörð Bjarmason
2022-01-27 16:22 ` [PATCH v4 6/7] builtin/submodule--helper.c: rename "suc" variable to "opt" Ævar Arnfjörð Bjarmason
2022-01-27 16:22 ` [PATCH v4 7/7] submodule: move core cmd_update() logic to C Ævar Arnfjörð Bjarmason
2022-01-27 21:55 ` Glen Choo
2022-01-28 12:56 ` [PATCH v5 0/9] submodule: convert the rest of 'update' " Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 1/9] submodule--helper: get remote names from any repository Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 2/9] submodule--helper: refactor get_submodule_displaypath() Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 3/9] submodule--helper: allow setting superprefix for init_submodule() Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 4/9] submodule--helper: run update using child process struct Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 5/9] builtin/submodule--helper.c: reformat designated initializers Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 6/9] builtin/submodule--helper.c: rename option variables to "opt" Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 7/9] submodule--helper: don't use bitfield indirection for parse_options() Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 8/9] submodule tests: test for init and update failure output Ævar Arnfjörð Bjarmason
2022-01-28 12:56 ` [PATCH v5 9/9] submodule: move core cmd_update() logic to C Ævar Arnfjörð Bjarmason
2022-02-03 0:18 ` Glen Choo
2022-02-03 2:26 ` Ævar Arnfjörð Bjarmason
2022-02-03 8:15 ` Ævar Arnfjörð Bjarmason
2022-02-03 17:35 ` Glen Choo
2022-02-08 8:39 ` [PATCH v6 00/16] submodule: convert the rest of 'update' " Glen Choo
2022-02-08 8:39 ` [PATCH v6 01/16] submodule--helper: get remote names from any repository Glen Choo
2022-02-08 8:39 ` [PATCH v6 02/16] submodule--helper: refactor get_submodule_displaypath() Glen Choo
2022-02-08 8:39 ` [PATCH v6 03/16] submodule--helper: allow setting superprefix for init_submodule() Glen Choo
2022-02-08 8:39 ` [PATCH v6 04/16] submodule--helper: run update using child process struct Glen Choo
2022-02-08 8:39 ` [PATCH v6 05/16] builtin/submodule--helper.c: reformat designated initializers Glen Choo
2022-02-08 8:39 ` [PATCH v6 06/16] builtin/submodule--helper.c: rename option variables to "opt" Glen Choo
2022-02-08 8:39 ` [PATCH v6 07/16] submodule--helper: don't use bitfield indirection for parse_options() Glen Choo
2022-02-08 8:39 ` [PATCH v6 08/16] submodule tests: test for init and update failure output Glen Choo
2022-02-08 8:39 ` [PATCH v6 09/16] submodule--helper: remove update-module-mode Glen Choo
2022-02-08 8:39 ` [PATCH v6 10/16] submodule--helper: reorganize code for sh to C conversion Glen Choo
2022-02-08 8:39 ` [PATCH v6 11/16] submodule--helper run-update-procedure: remove --suboid Glen Choo
2022-02-08 8:39 ` [PATCH v6 12/16] submodule--helper run-update-procedure: learn --remote Glen Choo
2022-02-08 8:39 ` [PATCH v6 13/16] submodule--helper: remove ensure-core-worktree Glen Choo
2022-02-08 8:39 ` [PATCH v6 14/16] submodule--helper update-clone: learn --init Glen Choo
2022-02-08 8:39 ` [PATCH v6 15/16] submodule--helper: move functions around Glen Choo
2022-02-08 8:39 ` [PATCH v6 16/16] submodule: move core cmd_update() logic to C Glen Choo
2022-02-10 9:28 ` [PATCH v7 00/20] submodule: convert the rest of 'update' " Glen Choo
2022-02-10 9:28 ` [PATCH v7 01/20] submodule--helper: get remote names from any repository Glen Choo
2022-02-10 9:28 ` [PATCH v7 02/20] submodule--helper: refactor get_submodule_displaypath() Glen Choo
2022-02-12 14:24 ` Ævar Arnfjörð Bjarmason
2022-02-10 9:28 ` [PATCH v7 03/20] submodule--helper: allow setting superprefix for init_submodule() Glen Choo
2022-02-12 14:30 ` Ævar Arnfjörð Bjarmason
2022-02-10 9:28 ` [PATCH v7 04/20] submodule--helper: run update using child process struct Glen Choo
2022-02-12 14:33 ` Ævar Arnfjörð Bjarmason
2022-02-10 9:28 ` [PATCH v7 05/20] builtin/submodule--helper.c: reformat designated initializers Glen Choo
2022-02-10 9:28 ` [PATCH v7 06/20] builtin/submodule--helper.c: rename option variables to "opt" Glen Choo
2022-02-10 9:28 ` [PATCH v7 07/20] submodule--helper: don't use bitfield indirection for parse_options() Glen Choo
2022-02-10 9:28 ` [PATCH v7 08/20] submodule tests: test for init and update failure output Glen Choo
2022-02-10 9:28 ` [PATCH v7 09/20] submodule--helper: remove update-module-mode Glen Choo
2022-02-12 14:35 ` Ævar Arnfjörð Bjarmason
2022-02-10 9:28 ` [PATCH v7 10/20] submodule--helper: reorganize code for sh to C conversion Glen Choo
2022-02-10 9:28 ` [PATCH v7 11/20] submodule--helper run-update-procedure: remove --suboid Glen Choo
2022-02-10 9:28 ` [PATCH v7 12/20] submodule--helper run-update-procedure: learn --remote Glen Choo
2022-02-12 14:38 ` Ævar Arnfjörð Bjarmason
2022-02-10 9:28 ` [PATCH v7 13/20] submodule--helper: remove ensure-core-worktree Glen Choo
2022-02-10 9:28 ` [PATCH v7 14/20] submodule--helper update-clone: learn --init Glen Choo
2022-02-10 9:28 ` [PATCH v7 15/20] submodule--helper: move functions around Glen Choo
2022-02-12 14:41 ` Ævar Arnfjörð Bjarmason
2022-02-10 9:28 ` [PATCH v7 16/20] submodule--helper: reduce logic in run_update_procedure() Glen Choo
2022-02-10 9:28 ` [PATCH v7 17/20] submodule: move core cmd_update() logic to C Glen Choo
2022-02-10 9:34 ` Glen Choo
2022-02-10 9:28 ` [PATCH v7 18/20] fixup! submodule--helper run-update-procedure: remove --suboid Glen Choo
2022-02-12 14:41 ` Ævar Arnfjörð Bjarmason
2022-02-10 9:28 ` [PATCH v7 19/20] fixup! submodule--helper run-update-procedure: learn --remote Glen Choo
2022-02-12 14:43 ` Ævar Arnfjörð Bjarmason
2022-02-10 9:28 ` [PATCH v7 20/20] fixup! submodule: move core cmd_update() logic to C Glen Choo
2022-02-12 14:45 ` [PATCH v7 00/20] submodule: convert the rest of 'update' " Ævar Arnfjörð Bjarmason
2022-02-17 5:44 ` Glen Choo
2022-02-17 9:17 ` Ævar Arnfjörð Bjarmason
2022-02-17 16:14 ` Glen Choo
2022-02-13 5:54 ` Junio C Hamano
2022-02-13 6:14 ` Junio C Hamano
2022-02-14 16:37 ` Glen Choo
2022-02-14 17:19 ` Ævar Arnfjörð Bjarmason
2022-02-15 9:34 ` Glen Choo
2022-02-14 17:34 ` Junio C Hamano
2022-02-15 9:31 ` Glen Choo
2022-02-15 9:47 ` Glen Choo
2021-10-14 21:50 ` [PATCH 00/13] " Glen Choo
2021-10-15 9:13 ` Atharva Raykar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013051805.45662-1-raykar.ath@gmail.com \
--to=raykar.ath@gmail.com \
--cc=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=pc44800@gmail.com \
--cc=periperidip@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).