From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: j6t@kdbg.org, gitster@pobox.com, avarab@gmail.com,
jonathantanmy@google.com, ramsay@ramsayjones.plus.com,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH v5 0/3] js/win-lazyload-buildfix
Date: Tue, 28 Sep 2021 20:19:37 -0700 [thread overview]
Message-ID: <20210929031940.97092-1-carenas@gmail.com> (raw)
In-Reply-To: <20210929004832.96304-1-carenas@gmail.com>
This is a reroll of v3, merged in seen at 906546091d (Merge branch
'js/win-lazyload-buildfix' into jch, 2021-09-28) and that provides a
buildfix for a non standard setup found and provided by Hannes, plus
cleanup for confusing issues reported by Ævar and Jonathan Tan due
to the original implementation of cb/pedantic-build-for-developers
now in master.
v5
- remove unnecessary export of a make variable as suggested by Ramsay
v4
- add a third patch based on feedback from cb/pedantic-build-for-developers
in master and including suggestions by Ævar on a similar patch posted as
part of a different series.
v3
- fixup to patch1 to help usability and typo fixes from Eric and Junio.
v2
- add a second patch to avoid CI build issues caused by the first and retire
now obsoleted -Wno-incompatible-pointer-types.
v1
- first patch with a build fix when -Wno-incompatible-pointer-types (included
with 6a8cbc41ba (developer: enable pedantic by default, 2021-09-03)) was
not in effect.
Carlo Marcelo Arenas Belón (2):
lazyload.h: use an even more generic function pointer than FARPROC
Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format better
Johannes Sixt (1):
lazyload.h: fix warnings about mismatching function pointer types
compat/win32/lazyload.h | 14 +++++++++-----
config.mak.dev | 8 ++++++--
config.mak.uname | 6 +++++-
3 files changed, 20 insertions(+), 8 deletions(-)
Range-diff against v4:
1: d2c470f9bc = 1: d2c470f9bc lazyload.h: fix warnings about mismatching function pointer types
2: 2d84c4ed57 = 2: 2d84c4ed57 lazyload.h: use an even more generic function pointer than FARPROC
3: a731848d01 ! 3: 0d4f097db9 Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format better
@@ config.mak.uname: ifeq ($(uname_S),NONSTOP_KERNEL)
pathsep = ;
HAVE_ALLOCA_H = YesPlease
NO_PREAD = YesPlease
-@@ config.mak.uname: ifeq ($(uname_S),QNX)
- NO_STRLCPY = YesPlease
- endif
-
-+export uname_S
-+
- vcxproj:
- # Require clean work tree
- git update-index -q --refresh && \
--
2.33.0.955.gee03ddbf0e
next prev parent reply other threads:[~2021-09-29 3:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 19:56 [PATCH cb/pedantic-build-for-developers] lazyload.h: fix warnings about mismatching function pointer types Johannes Sixt
2021-09-22 20:16 ` Carlo Arenas
2021-09-22 21:21 ` Johannes Sixt
2021-09-23 6:20 ` Carlo Arenas
2021-09-23 6:03 ` [PATCH] lazyload.h: use an even more generic function pointer than FARPROC Carlo Marcelo Arenas Belón
2021-09-23 6:33 ` Johannes Sixt
2021-09-23 6:49 ` Carlo Arenas
2021-09-23 6:52 ` [PATCH v2] " Carlo Marcelo Arenas Belón
2021-09-26 10:05 ` [PATCH v3 0/2] js/win-lazyload-buildfix Carlo Marcelo Arenas Belón
2021-09-26 10:05 ` [PATCH v3 1/2] lazyload.h: fix warnings about mismatching function pointer types Carlo Marcelo Arenas Belón
2021-09-27 2:58 ` Eric Sunshine
2021-09-26 10:05 ` [PATCH v3 2/2] lazyload.h: use an even more generic function pointer than FARPROC Carlo Marcelo Arenas Belón
2021-09-27 16:35 ` Junio C Hamano
2021-09-27 18:50 ` Carlo Arenas
2021-09-27 20:13 ` Junio C Hamano
2021-09-29 0:48 ` [PATCH v4 0/3] js/win-lazyload-buildfix Carlo Marcelo Arenas Belón
2021-09-29 0:48 ` [PATCH v4 1/3] lazyload.h: fix warnings about mismatching function pointer types Carlo Marcelo Arenas Belón
2021-09-29 0:48 ` [PATCH v4 2/3] lazyload.h: use an even more generic function pointer than FARPROC Carlo Marcelo Arenas Belón
2021-09-29 0:48 ` [PATCH v4 3/3] Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format better Carlo Marcelo Arenas Belón
2021-09-29 1:14 ` Ramsay Jones
2021-09-29 3:19 ` Carlo Marcelo Arenas Belón [this message]
2021-09-29 3:19 ` [PATCH v5 1/3] lazyload.h: fix warnings about mismatching function pointer types Carlo Marcelo Arenas Belón
2021-09-29 3:19 ` [PATCH v5 2/3] lazyload.h: use an even more generic function pointer than FARPROC Carlo Marcelo Arenas Belón
2021-09-29 3:19 ` [PATCH v5 3/3] Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format better Carlo Marcelo Arenas Belón
2021-09-23 21:00 ` [PATCH cb/pedantic-build-for-developers] lazyload.h: fix warnings about mismatching function pointer types Carlo Arenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929031940.97092-1-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jonathantanmy@google.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).