git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Lénaïc Huard" <lenaic@lhuard.fr>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Derrick Stolee" <dstolee@microsoft.com>,
	"Derrick Stolee" <stolee@gmail.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Lénaïc Huard" <lenaic@lhuard.fr>
Subject: [PATCH 0/1] maintenance: fix test t7900-maintenance.sh
Date: Mon, 27 Sep 2021 23:30:15 +0200	[thread overview]
Message-ID: <20210927213016.21714-1-lenaic@lhuard.fr> (raw)

The test t7900-maintenance.sh seems to be currently broken on the
master branch on some platforms.
Since commit b681b191, one of the test leverages `systemd-analyze
verify` utility to check the correctness of systemd unit files
generated by git.

But, whereas it works on Arch Linux with a recent version of systemd,
it fails on Ubuntu 18.04 and systemd 237 with this error [1]:

  Failed to create /user.slice/user-1000.slice/session-44.scope/init.scope control group: Permission denied
  Failed to initialize manager: Permission denied

It also fails on CentOS 7.9 and systemd 219 with this error [2]:

    Failed to open /dev/tty0: Permission denied
    Failed to load systemd/user/git-maintenance@.service: Invalid argument

This patch changes the prerequisite used in the test to check if
`system-analyze verify` can be used.
As a result, this step should be now skipped on the two
above-mentioned platforms instead of making the test fail.

[1] https://lore.kernel.org/git/4c0c1fd4-f3f4-5e3a-abd2-0350c18b18b7@gmail.com/
[2] https://lore.kernel.org/git/874ka618n4.fsf@evledraar.gmail.com/

Lénaïc Huard (1):
  maintenance: fix test t7900-maintenance.sh

 t/t7900-maintenance.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.33.0


             reply	other threads:[~2021-09-27 21:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 21:30 Lénaïc Huard [this message]
2021-09-27 21:30 ` [PATCH 1/1] maintenance: fix test t7900-maintenance.sh Lénaïc Huard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210927213016.21714-1-lenaic@lhuard.fr \
    --to=lenaic@lhuard.fr \
    --cc=avarab@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stolee@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).