git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Miriam Rubio <mirucam@gmail.com>
To: git@vger.kernel.org
Cc: Miriam Rubio <mirucam@gmail.com>
Subject: [PATCH v7 0/6] Finish converting git bisect to C part 4
Date: Mon, 13 Sep 2021 19:38:58 +0200	[thread overview]
Message-ID: <20210913173905.44438-1-mirucam@gmail.com> (raw)

These patches correspond to a fourth part of patch series 
of Outreachy project "Finish converting `git bisect` from shell to C" 
started by Pranit Bauva and Tanushree Tumane
(https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
continued by me.

This fourth part is formed by reimplementations of some `git bisect` 
subcommands, addition of tests and removal of some temporary subcommands.

These patch series emails were generated from:
https://gitlab.com/mirucam/git/commits/git-bisect-work-part4-v7.

I would like to thank Junio Hamano and Johannes Schindelin for reviewing
this patch series.

Specific changes
----------------

[1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases
* Remove unnecessary redirections to /dev/null and my_bisect_log.txt
---

[2/6]t6030-bisect-porcelain: add test for bisect visualize
* Remove redirection and add double quotes to test's filename

---

[3/6]run-command: make `exists_in_PATH()` non-static
* Amend commit message.
* Change parameter name.
---

[4/6]bisect--helper: reimplement `bisect_visualize()` shell function in C
* Add brackets to an if expression.
---

[5/6] bisect--helper: reimplement `bisect_run` shell function in C
* Add two fflush(stdout) in dup2 dance.
* Rewrite if-else condition.


---


Miriam Rubio (3):
  t6030-bisect-porcelain: add tests to control bisect run exit cases
  t6030-bisect-porcelain: add test for bisect visualize
  bisect--helper: retire `--bisect-next-check` subcommand

Pranit Bauva (2):
  run-command: make `exists_in_PATH()` non-static
  bisect--helper: reimplement `bisect_visualize()` shell function in C

Tanushree Tumane (1):
  bisect--helper: reimplement `bisect_run` shell function in C

 builtin/bisect--helper.c    | 158 ++++++++++++++++++++++++++++++++++--
 git-bisect.sh               |  87 +-------------------
 run-command.c               |   4 +-
 run-command.h               |  12 +++
 t/t6030-bisect-porcelain.sh |  18 ++++
 5 files changed, 184 insertions(+), 95 deletions(-)

-- 
2.29.2


             reply	other threads:[~2021-09-13 17:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 17:38 Miriam Rubio [this message]
2021-09-13 17:38 ` [PATCH v7 1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases Miriam Rubio
2021-09-13 17:39 ` [PATCH v7 2/6] t6030-bisect-porcelain: add test for bisect visualize Miriam Rubio
2021-09-13 17:39 ` [PATCH v7 3/6] run-command: make `exists_in_PATH()` non-static Miriam Rubio
2021-09-13 17:39 ` [PATCH v7 4/6] bisect--helper: reimplement `bisect_visualize()` shell function in C Miriam Rubio
2021-09-13 17:39 ` [PATCH v7 5/6] bisect--helper: reimplement `bisect_run` " Miriam Rubio
2021-09-13 19:27   ` Ævar Arnfjörð Bjarmason
2021-09-13 17:39 ` [PATCH v7 6/6] bisect--helper: retire `--bisect-next-check` subcommand Miriam Rubio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913173905.44438-1-mirucam@gmail.com \
    --to=mirucam@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).