From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: hanwen@google.com, "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH 1/3] fixup! refs: RFC: Reftable support for git-core
Date: Wed, 1 Sep 2021 22:30:21 -0700 [thread overview]
Message-ID: <20210902053023.44006-2-carenas@gmail.com> (raw)
In-Reply-To: <20210902053023.44006-1-carenas@gmail.com>
need to reorder the variables to hopefully make it easier to see why
they might not be used since assert will compile out itself with -DNDEBUG.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
refs/reftable-backend.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
index 61ee144e19..5d733b0496 100644
--- a/refs/reftable-backend.c
+++ b/refs/reftable-backend.c
@@ -127,10 +127,11 @@ static void clear_reftable_log_record(struct reftable_log_record *log)
static void fill_reftable_log_record(struct reftable_log_record *log)
{
- const char *info = git_committer_info(0);
struct ident_split split = { NULL };
- int result = split_ident_line(&split, info, strlen(info));
int sign = 1;
+ MAYBE_UNUSED const char *info = git_committer_info(0);
+ MAYBE_UNUSED int result = split_ident_line(&split, info, strlen(info));
+
assert(0 == result);
reftable_log_record_release(log);
--
2.33.0.481.g26d3bed244
next prev parent reply other threads:[~2021-09-02 5:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 5:30 [PATCH 0/3] hn/reftable: fixes for building with -DNDEBUG Carlo Marcelo Arenas Belón
2021-09-02 5:30 ` Carlo Marcelo Arenas Belón [this message]
2021-09-02 9:05 ` [PATCH 1/3] fixup! refs: RFC: Reftable support for git-core Jeff King
2021-09-02 9:26 ` Han-Wen Nienhuys
2021-09-02 5:30 ` [PATCH 2/3] fixup! reftable: add merged table view Carlo Marcelo Arenas Belón
2021-09-02 5:30 ` [PATCH 3/3] fixup! reftable: add a heap-based priority queue for reftable records Carlo Marcelo Arenas Belón
2021-09-02 9:09 ` Jeff King
2021-09-02 20:08 ` Junio C Hamano
2021-09-02 22:40 ` Jeff King
2021-09-03 4:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902053023.44006-2-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).