From: Jonathan Tan <jonathantanmy@google.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, kim@eagain.st,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)
Date: Tue, 31 Aug 2021 15:02:08 -0700 [thread overview]
Message-ID: <20210831220208.3924051-1-jonathantanmy@google.com> (raw)
In-Reply-To: <xmqq35qr7mq5.fsf@gitster.g>
> * ka/want-ref-in-namespace (2021-08-13) 3 commits
> - docs: clarify the interaction of transfer.hideRefs and namespaces
> - upload-pack.c: treat want-ref relative to namespace
> - t5730: introduce fetch command helper
>
> "git upload-pack" which runs on the other side of "git fetch"
> forgot to take the ref namespaces into account when handling
> want-ref requests.
Sorry for not being able to look at this until now, but:
Reviewed-by: Jonathan Tan <jonathantanmy@google.com>
Thanks for addressing my comment about the failing tests to be written
in success/failure pairs [1] - I see that that has been done in patch 2.
[1] https://lore.kernel.org/git/20210802210644.3432544-1-jonathantanmy@google.com/
next prev parent reply other threads:[~2021-08-31 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 1:19 What's cooking in git.git (Aug 2021, #09; Sun, 29) Junio C Hamano
2021-08-30 11:00 ` Ævar Arnfjörð Bjarmason
2021-08-30 12:23 ` Han-Wen Nienhuys
2021-08-30 13:27 ` Ævar Arnfjörð Bjarmason
2021-08-30 13:58 ` Han-Wen Nienhuys
2021-08-30 23:44 ` Junio C Hamano
2021-08-31 3:39 ` Junio C Hamano
2021-09-01 5:04 ` SZEDER Gábor
2021-08-30 14:02 ` Derrick Stolee
2021-08-31 0:29 ` Junio C Hamano
2021-08-31 22:02 ` Jonathan Tan [this message]
2021-09-01 14:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831220208.3924051-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kim@eagain.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).