git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] test-lib: set GIT_CEILING_DIRECTORIES to protect the surrounding repository
Date: Sun, 29 Aug 2021 11:15:46 +0200	[thread overview]
Message-ID: <20210829091546.GH2257957@szeder.dev> (raw)
In-Reply-To: <CAPUEspg43gxRiVydtaYdM06ObQGYUVn6oThjg1VTR+EfsxRVjA@mail.gmail.com>

On Sat, Aug 28, 2021 at 12:56:24PM -0700, Carlo Arenas wrote:
> On Sat, Aug 28, 2021 at 5:15 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
> > diff --git a/t/test-lib.sh b/t/test-lib.sh
> > index abcfbed6d6..a1e0182c2f 100644
> > --- a/t/test-lib.sh
> > +++ b/t/test-lib.sh
> > @@ -1343,7 +1343,8 @@ fi
> >  GIT_TEMPLATE_DIR="$GIT_BUILD_DIR"/templates/blt
> >  GIT_CONFIG_NOSYSTEM=1
> >  GIT_ATTR_NOSYSTEM=1
> > -export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG_NOSYSTEM GIT_ATTR_NOSYSTEM
> > +GIT_CEILING_DIRECTORIES="$GIT_BUILD_DIR"
> 
> this wouldn't work as expected with --root and would be IMHO safer
> anyway if using instead
> 
>   GIT_CEILING_DIRECTORIES="$TRASH_DIRECTORY/.."

Thanks, I completely forgot about '--root'.


  reply	other threads:[~2021-08-29  9:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28 12:13 [PATCH] test-lib: set GIT_CEILING_DIRECTORIES to protect the surrounding repository SZEDER Gábor
2021-08-28 19:56 ` Carlo Arenas
2021-08-29  9:15   ` SZEDER Gábor [this message]
2021-08-29  9:25 ` [PATCH v2] " SZEDER Gábor
2021-08-31 14:40   ` Ævar Arnfjörð Bjarmason
2021-09-01  4:58     ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210829091546.GH2257957@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).