From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 087C21F8C6 for ; Wed, 4 Aug 2021 21:36:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232088AbhHDVgo (ORCPT ); Wed, 4 Aug 2021 17:36:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231893AbhHDVgo (ORCPT ); Wed, 4 Aug 2021 17:36:44 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED34CC0613D5 for ; Wed, 4 Aug 2021 14:36:29 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id h13so3779922wrp.1 for ; Wed, 04 Aug 2021 14:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wzxAUNPPWn8Q0odkgIESwFsMwv7jMh0SARIz4RBfgPI=; b=LNb0j4SdLKtDEv12O3ShUCEFmapUhOArlCeWEr255VwYTpADrS7J7qy9jD1Xvac1XD NiWWV2wwr7WRUghrL4KtBkRUP88QRXwyTIpxgtPlModgr25L40P8bzzYxvA4FRKezLJb eIqYHKxbFTgcZIQvw/OnZTBCgldokg0ZamcOk4OgnfZCbhDxvNMs9VPJh2BmDT56ZgzZ 8yoNAlPIaRDvG/k9lvgnendjFWZedGRjpbSXxwbeEaxWiSze6bxyGma1QI4gTm5m1E2m hteO0C4vAgeDfPV5IY/L2oxdTB9heaeacONhNKrqZJ6bKDhvGRJS/VsHel4KOnN5hRl8 MTPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wzxAUNPPWn8Q0odkgIESwFsMwv7jMh0SARIz4RBfgPI=; b=nMRuEBDNwbdx7Ny8HSZyW8MQ3pdJ6sihyjTxrFxZnTQoUG/EFYtmdZW09ZClqHjSzv kClgWL3Mxr+E/TTJ3z5aXxhkXio23FJHtwp+LufyEY1ZOg2dW2SzhcpAslZ7VJAdW6kM 7HNC6fqS4ELjDHTA328sS1aHnwMTLdZ9BGMvMiLwRks6hH0FhcK0oR9A7NzEMqJSrD++ mfweArWek61xKI5dF4/l3I0CNhoTprRDYVQa0LQ5SLecCIX3EjfgoUDYBrdWoKRNluAb P1C4z6wOR66gynZffLg6ydWi/yCDJjmTYSDU/in5YajHnFL08Xtyjo/QDuTrPPNU8MSw e0gQ== X-Gm-Message-State: AOAM532iUhQUsuEvJpP+9MeepjjtiB5N2DY8RYlhDL2FaBedOa8ilDnc NxauIZnUsLS+pM4rG2M2z28= X-Google-Smtp-Source: ABdhPJw4FbZ+sxbBSzFZHuLkg+ZPKshziDZStvk3l80IjGtV605t5y7HvgX0uMew72Ymg1BAhljKpQ== X-Received: by 2002:a5d:49c8:: with SMTP id t8mr1301824wrs.365.1628112988547; Wed, 04 Aug 2021 14:36:28 -0700 (PDT) Received: from szeder.dev (78-131-14-24.pool.digikabel.hu. [78.131.14.24]) by smtp.gmail.com with ESMTPSA id c15sm3895039wrw.93.2021.08.04.14.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 14:36:28 -0700 (PDT) Date: Wed, 4 Aug 2021 23:36:26 +0200 From: SZEDER =?utf-8?B?R8OhYm9y?= To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Junio C Hamano , git@vger.kernel.org, Taylor Blau , Emily Shaffer Subject: Re: What's cooking in git.git (Aug 2021, #02; Tue, 3) Message-ID: <20210804213626.GI23408@szeder.dev> References: <87wnp1mqv2.fsf@evledraar.gmail.com> <87lf5hm0v7.fsf@evledraar.gmail.com> <20210804212825.GH23408@szeder.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210804212825.GH23408@szeder.dev> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 04, 2021 at 11:28:25PM +0200, SZEDER Gábor wrote: > On Wed, Aug 04, 2021 at 09:53:02PM +0200, Ævar Arnfjörð Bjarmason wrote: > > > > On Wed, Aug 04 2021, Junio C Hamano wrote: > > > > > Ævar Arnfjörð Bjarmason writes: > > > > > >>> * ab/test-columns (2021-08-02) 3 commits > > >>> - test-lib.sh: use GIT_TEST_COLUMNS over COLUMNS > > >>> - test-lib-functions.sh: add a test_with_columns function > > >>> - test-lib-functions.sh: rename test_must_fail_acceptable() > > >> > > >> We're going to need this or another solution to the v2.33.0-rc0 > > >> regression in c49a177beca (test-lib.sh: set COLUMNS=80 for --verbose > > >> repeatability, 2021-06-29) before the final v2.33.0. > > > > > > Just a question. Is that true? Wouldn't a system that needs these > > > on top of c49a177beca already break the tests without c49a177beca? > > > > > > IOW, is c49a177beca truly a "regression", or is it merely "a half > > > solution that solves for most but not all platforms"? > > > > Yes, because with c49a177beca your tests only break if you use the > > --verbose option, i.e. if your stderr is connected to a terminal. I.e.: > > > > ./t0500-progress-display.sh --verbose > > > > So in practice it mostly affects git developers who run with --verbose, > > but probably nobody doing a build in the wild. > > > > With c49a177beca they break on e.g.: > > > > /bin/bash ./t0500-progress-display.sh > > > > If your bash is recent enough, so "make test" if you're on a system with > > a recent bash whose /bin/sh is /bin/bash. > > > > This is because post-c49a177beca we don't "unset" COLUMNS anymore, which > > bash takes as license to update it. > > > > So we really do need that series in before the release to avoid that > > common annoyance, a revert of c49a177beca is also possible, i.e. it > > would still leave things broken under --verbose, but that breakage is > > rare and existed before v2.33. > > > > I think given the triviality of the fixes and that the cause is > > well-understood it makes sense to go forward in this case. > > On one hand, there is feedback to be addressed: > > https://public-inbox.org/git/20210802171429.GC23408@szeder.dev/ > > OTOH, setting the checkwinsize is the truly trivial, minimal, reliable Oh, this should have been s/setting/turning off/ > and uncontroversial fix for this issue, and IMO that should go into > the next release. > > This fix in this patch series is not trivial: it introduces yet > another GIT_TEST variable and a helper function that developers will > have to remember to use in the future. Worse, this means that despite > aiming for future proofing I can't consider this approach future > proof, because it's easy to forget about such a rarely used test > helper function, and if anyone introduces yet another test setting > COLUMNS, then that will be prone to similar failures when run with > Bash. > > I don't think that in this case we should aim for future proofing when > the cost is the additional cognitive load of yet another helper > function. I would instead prefer to go with the really trivial fix > for now and wait whether this issue pops up again with other shell or > terminal, hoping that this issue is a "one-hit-wonder" [1] and it > won't happen ever again. > > > [1] "one-hit-wonder" as in: > https://en.wikipedia.org/wiki/Bloom_filter#Cache_filtering >